From owner-svn-src-all@FreeBSD.ORG  Sun Sep  8 16:24:58 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 6E8BB24B;
 Sun,  8 Sep 2013 16:24:58 +0000 (UTC)
 (envelope-from edschouten@gmail.com)
Received: from mail-vb0-x22d.google.com (mail-vb0-x22d.google.com
 [IPv6:2607:f8b0:400c:c02::22d])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id EAC51258A;
 Sun,  8 Sep 2013 16:24:57 +0000 (UTC)
Received: by mail-vb0-f45.google.com with SMTP id e15so3317597vbg.18
 for <multiple recipients>; Sun, 08 Sep 2013 09:24:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=7//j43qttm7G6L3zRMDPmIPY2HpjxezRAPMLTdHQV/E=;
 b=gjvhHKuRIcp5Zxz5Y0Sb75t7Nik0DbvvyMUfQK4woUHa1w9JhxHiS+vhmtOu7kxxZH
 UAD8gOANfB3wxm4piObhwSCmHFy/rCh7mjFCdVEALrZvwJleoYLTMOt+PT/HJ1LCwAfB
 fqEEEdoYykTytFwkHP+MQaeDMd+HalGjgKZiGRM87F0l6RQQnUfx5fuCnS7QnN0eeshZ
 K5hqK7TQiDSN4UiZzgtQQ4liv6NMtm3FZurDe8og51me+uZ/QJ2xDtrHjUdU3ipmLdpo
 0bbGwO0rxifdzSsz5GUyc26kTinNGya5LDFKP6xW+TZ1NeIW5J0fJT4m8ci/A+jVw06w
 ganA==
MIME-Version: 1.0
X-Received: by 10.58.100.234 with SMTP id fb10mr13150565veb.5.1378657496222;
 Sun, 08 Sep 2013 09:24:56 -0700 (PDT)
Sender: edschouten@gmail.com
Received: by 10.220.115.206 with HTTP; Sun, 8 Sep 2013 09:24:56 -0700 (PDT)
In-Reply-To: <201309071345.r87Djj0P003439@svn.freebsd.org>
References: <201309071345.r87Djj0P003439@svn.freebsd.org>
Date: Sun, 8 Sep 2013 18:24:56 +0200
X-Google-Sender-Auth: _Yrz3lxeMMzzC0AZoacNTlXaLSw
Message-ID: <CAJOYFBAmmmd29N_W+yFK3m=z0otF47dWO2Kd4w42aQcCCt59bg@mail.gmail.com>
Subject: Re: svn commit: r255359 - in head/sys: cddl/dev/dtrace dev/firewire
 dev/vkbd security/audit
From: Ed Schouten <ed@80386.nl>
To: Davide Italiano <davide@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Sep 2013 16:24:58 -0000

2013/9/7 Davide Italiano <davide@freebsd.org>:
> Log:
>   - Use make_dev_credf(MAKEDEV_REF) instead of the race-prone make_dev()+
>   dev_ref() in the clone handlers that still use it.
>   - Don't set SI_CHEAPCLONE flag, it's not used anywhere neither in devfs
>   (for anything real)

Wait. This piece of code is never used on FreeBSD HEAD, right? See
dtrace_load.c:

#if __FreeBSD_version < 800039
        /* Enable device cloning. */
        clone_setup(&dtrace_clones);

        /* Setup device cloning events. */
        eh_tag = EVENTHANDLER_REGISTER(dev_clone, dtrace_clone, 0,
1000);
#else
        dtrace_dev = make_dev(&dtrace_cdevsw, 0, UID_ROOT, GID_WHEEL,
0600,
            "dtrace/dtrace");
        helper_dev = make_dev(&helper_cdevsw, 0, UID_ROOT, GID_WHEEL,
0660,
            "dtrace/helper");
#endif

-- 
Ed Schouten <ed@80386.nl>