Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Jun 2007 10:53:47 GMT
From:      Roman Divacky <rdivacky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 120828 for review
Message-ID:  <200706031053.l53Arlso013578@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=120828

Change 120828 by rdivacky@rdivacky_witten on 2007/06/03 10:52:47

	Remove pointless path and pathseg arguments from kern_common_* functions.
	They serve no purpose...

Affected files ...

.. //depot/projects/soc2007/rdivacky/linux_at/sys/kern/vfs_syscalls.c#6 edit

Differences ...

==== //depot/projects/soc2007/rdivacky/linux_at/sys/kern/vfs_syscalls.c#6 (text+ko) ====

@@ -87,10 +87,10 @@
     const struct timespec *, int, int);
 static int vn_access(struct vnode *vp, int user_flags, struct ucred *cred,
     struct thread *td);
-static int kern_common_open(struct thread *td, char *path, enum uio_seg pathseg, 
-    int flags, int mode, struct nameidata *nd);
-static int kern_common_access(struct thread *td, char *path, enum uio_seg pathseg, 
-    int flags, struct nameidata *nd);
+static int kern_common_open(struct thread *td, int flags, int mode,
+    struct nameidata *nd);
+static int kern_common_access(struct thread *td, int flags,
+    struct nameidata *nd);
 static int kern_common_stat(struct thread *td, struct stat *sbp,
     struct nameidata *nd);
 
@@ -970,7 +970,7 @@
 	AUDIT_ARG(mode, mode);
 	NDINIT(&nd, LOOKUP, FOLLOW | AUDITVNODE1 | MPSAFE, pathseg, path, td);
 
-	return kern_common_open(td, path, pathseg, flags, mode, &nd);
+	return kern_common_open(td, flags, mode, &nd);
 }
 
 int
@@ -999,15 +999,14 @@
 
 	NDINIT_AT(&nd, LOOKUP, FOLLOW | AUDITVNODE1 | MPSAFE, pathseg, path, td, dir_vn);
 
-	error = kern_common_open(td, path, pathseg, flags, mode, &nd);
+	error = kern_common_open(td, flags, mode, &nd);
 	if (dirfd != AT_FDCWD)
 		vrele(dir_vn);
 	return (error);
 }
 
 static int
-kern_common_open(struct thread *td, char *path, enum uio_seg pathseg, int flags,
-    int mode, struct nameidata *nd)
+kern_common_open(struct thread *td, int flags, int mode, struct nameidata *nd)
 {
 	struct proc *p = td->td_proc;
 	struct filedesc *fdp = p->p_fd;
@@ -1908,7 +1907,7 @@
 	NDINIT(&nd, LOOKUP, FOLLOW | LOCKLEAF | MPSAFE | AUDITVNODE1,
 	    pathseg, path, td);
 
-	return kern_common_access(td, path, pathseg, flags, &nd);
+	return kern_common_access(td, flags, &nd);
 }
 
 int
@@ -1933,15 +1932,14 @@
 	NDINIT_AT(&nd, LOOKUP, FOLLOW | LOCKLEAF | MPSAFE | AUDITVNODE1,
 	    pathseg, path, td, dir_vn);
 
-	error = kern_common_access(td, path, pathseg, flags, &nd);
+	error = kern_common_access(td, flags, &nd);
 	if (dirfd != AT_FDCWD)
 		vrele(dir_vn);
 	return (error);
 }
 
 static int
-kern_common_access(struct thread *td, char *path, enum uio_seg pathseg, int flags,
-	struct nameidata *nd)
+kern_common_access(struct thread *td, int flags, struct nameidata *nd)
 {
 	struct ucred *cred, *tmpcred;
 	struct vnode *vp;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706031053.l53Arlso013578>