From owner-freebsd-git@freebsd.org Sat Jan 9 17:56:41 2021 Return-Path: Delivered-To: freebsd-git@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B4E754DE1FD for ; Sat, 9 Jan 2021 17:56:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCnj43dsDz3nbg for ; Sat, 9 Jan 2021 17:56:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72d.google.com with SMTP id 143so11321918qke.10 for ; Sat, 09 Jan 2021 09:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wjPhmM4AtcKVfe+fNjaXUb+3oNsxa2TZUivjB7OjAug=; b=L3e1hRCvJidorD1vI1xC6OJDCdbO/SwwBFG/LMq6TzwmFzm8Y6TdzaTLFfcSmHdNh+ ZImHImmT/p/D5M0TY8id2jREaD9jLqr2I7LKRQbjScady+k2gVlfna7tUmfvmH4nTDsZ RLSufOgZvt9IQeZ1khsbfF0RXuZIyGzo5aaKjL13XWbgX/OnKpsJ5jkuwN4phvwe2Ona HGYJM73WcXHehKvhLvdK3RifZC5JgYqh4pS3DQQUqFxaShF5s7rs8v7U9IsNnynUK/WJ Y34dSRUac+Bx0rm0l8dvhHymg4Ad8Dh2S2LjLmZ7clhS/YN0nYGy80zHTpUUgKIYdgKP OLag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wjPhmM4AtcKVfe+fNjaXUb+3oNsxa2TZUivjB7OjAug=; b=qMm5iqIbwLRhqqKvGiqyCqD5/KwjF1AUAQLOQMFHvOT0abiG85dJ7ZpNhIqzQq+6GD SFus+h8Q+lJxUJ+x/XDJoRzrik/xaRNHpI9QRmCVnT97cq/qb2mdVpCEQoiNqgKg58tU NuHTINBFE52BovEkkYxNiTTBzbDr3oLM+zFDPHxH1RKEb/XEhvkCzdtQK86mQFzbuwvd I9mazTaDt4/wwtdY98rKTZxY16BpHGgD+Drwc+Z3Vgc/Ew9hqYzs/w8+g7AKzLl8vH1e hv5/Ue/4koFmbz5vMqjL3Ki1aQ6y7t40J0KmhEPZtDIj3lD3gPpdAuwiX6J1yQnNtFFp vTxQ== X-Gm-Message-State: AOAM5300D8V5Ti6Yl2AOhe9YQ0EZJvU26P6MEgZsAXFjB1hagrzbIMcQ Bc2jKogLKRbgMiUPReXPjVJBNmsf1yQ9zSqzwPUyOg== X-Google-Smtp-Source: ABdhPJz3nV93/uXhgqxxh/Z0KC6q/ZhKHVXtkH2VMiOHUw84To46GHXQSGD4/OXmh6Ts2rspXX7MJJT7I1FFHlc32SI= X-Received: by 2002:a37:8505:: with SMTP id h5mr9326064qkd.44.1610214999643; Sat, 09 Jan 2021 09:56:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Sat, 9 Jan 2021 10:56:28 -0700 Message-ID: Subject: Re: Patch Attribution To: Kyle Evans Cc: freebsd-git X-Rspamd-Queue-Id: 4DCnj43dsDz3nbg X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=L3e1hRCv; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.00 / 15.00]; ARC_NA(0.00)[]; MAILMAN_DEST(0.00)[freebsd-git]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; NEURAL_HAM_LONG(-1.00)[-0.998]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::72d:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72d:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::72d:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2021 17:56:41 -0000 On Sat, Jan 9, 2021 at 10:54 AM Warner Losh wrote: > > > On Sat, Jan 9, 2021 at 10:52 AM Kyle Evans wrote: > >> Hello! >> >> I haven't (that I recall) seen any particular guidance one way or the >> other, but what's the general feeling on "Submitted by" for patches >> that come in via Bugzilla without commit metadata vs. committing >> locally with --author="Name "? >> >> I did this with d36b5db and didn't receive any complaints, but I'm >> curious if we should be more actively promoting setting the author >> correctly whether the patch came in with it or not. I noted that >> Warner's meta doc[0] lists "Submitted-by" which is where my >> uncertainty comes from. >> > > My document should be updated. I think what you did is fine, and we should > document it as best practice. > If you write something, I'll land it :). We should also consider what to do for code we pull in from NetBSD, etc.