From owner-cvs-all Sun Jan 12 0:24: 1 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC17537B405; Sun, 12 Jan 2003 00:23:57 -0800 (PST) Received: from sccrmhc03.attbi.com (sccrmhc03.attbi.com [204.127.202.63]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D78743F3F; Sun, 12 Jan 2003 00:23:57 -0800 (PST) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by sccrmhc03.attbi.com (sccrmhc03) with ESMTP id <2003011208235500300cqghre>; Sun, 12 Jan 2003 08:23:56 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id AAA58045; Sun, 12 Jan 2003 00:23:54 -0800 (PST) Date: Sun, 12 Jan 2003 00:23:54 -0800 (PST) From: Julian Elischer To: Scott Long Cc: Alfred Perlstein , Jake Burkholder , Matthew Dillon , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... In-Reply-To: <3E2122F6.70400@btc.adaptec.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 12 Jan 2003, Scott Long wrote: > Alfred Perlstein wrote: > > > * Jake Burkholder [030111 22:46] wrote: > > > > >Its unnecessary code churn. I wouldn't be surprised if struct file was > > >used all the place in 3rd party modules, especially MAC modules. Now > > >they either need an ugly compat define or ugly idfefs. Some of your > > commits > > >were to code that's externally maintained. We've broken > > compatibility with > > >external code before for compelling reasons. This is not a > > compelling reason. > > > > > >You obviously don't think this is important, I do. If no one else > > cares about > > >this I'll shut up now. > > > > > > I prefer Jake's idea of just removing the casts where they are unneeded. > > > > This adds unneeded complexity and renaming that we don't need. > > > > It also reduces diffs to what will be 5-stable. > > > > With an re@ hat on, I agree with Alfred. When RELENG_5_0 was branched > we asked that gratuitous changes and API, ABI, etc changes be kept to a > minimum and that re@ be consulted before doing them. Cleaning up the code > is fine, changing the names and types of structure members in the API goes > against the spirit of what was requested. > > Please revert your changes to sys/sys/file.h. #define f_data f_union.generic it's even binary compatible. > > Scott > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message