Date: Mon, 2 Jan 2017 15:08:10 +0000 From: Matthew Seaman <matthew@FreeBSD.org> To: Jimmy Olgeni <olgeni@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r430355 - in head/lang: erlang erlang-runtime19 Message-ID: <56b7d3f5-56d9-26fc-da1d-be13ce32a213@FreeBSD.org> In-Reply-To: <201701021324.v02DOkom002681@repo.freebsd.org> References: <201701021324.v02DOkom002681@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--AWEDSiaSx2aBMGNTh3bQKoD3i9FK5j1No
Content-Type: multipart/mixed; boundary="VLKQUiRlumo5CnR4icbHmc0ugau0ghoeE";
protected-headers="v1"
From: Matthew Seaman <matthew@FreeBSD.org>
To: Jimmy Olgeni <olgeni@FreeBSD.org>, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <56b7d3f5-56d9-26fc-da1d-be13ce32a213@FreeBSD.org>
Subject: Re: svn commit: r430355 - in head/lang: erlang erlang-runtime19
References: <201701021324.v02DOkom002681@repo.freebsd.org>
In-Reply-To: <201701021324.v02DOkom002681@repo.freebsd.org>
--VLKQUiRlumo5CnR4icbHmc0ugau0ghoeE
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
On 02/01/2017 13:24, Jimmy Olgeni wrote:
> +.if !exists(/usr/sbin/dtrace)
> +OPTIONS_EXCLUDE+=3D DTRACE
> +.endif
> +
> +OPTIONS_EXCLUDE_FreeBSD_9=3D DTRACE
> +OPTIONS_EXCLUDE_FreeBSD_10=3D DTRACE
> +OPTIONS_EXCLUDE_i386=3D DTRACE
> +
I am not sure that the way you have enabled DTRACE by default makes much
sense. I investigated building ports via poudriere with DTRACE enabled
a little while back and I found
* poudriere jails need a copy of the host systems' kernel -- never
mind if that is a different OS version than what the jail is using.
* It's impossible to build successfully with enabled DTRACE when
crossbulding for i386 on a host system running amd64.
I've a pull request here: https://github.com/freebsd/poudriere/pull/410
to add a capability to null-mount the host system kernel into poudriere
jails which allows building with DTRACE enabled for 9 and 10 on an 11 hos=
t.
However, I suspect that most of these problems are artifacts of the way
poudriere uses jails to build for the various OS versions etc. Building
/natively/ on any of the combinations of OS and architecture might very
well work.
My recommendation would be to either leave DTRACE support present for
all OS/arch combinations, but disabled by default. Or to automatically
disable DTRACE if building under poudriere can be detected. Which means
unfortunately that precompiled pkgs wouldn't have DTRACE support enabled.=
Cheers,
Matthew
--VLKQUiRlumo5CnR4icbHmc0ugau0ghoeE--
--AWEDSiaSx2aBMGNTh3bQKoD3i9FK5j1No
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJ8BAEBCgBmBQJYamzaXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NTNBNjhCOTEzQTRFNkNGM0UxRTEzMjZC
QjIzQUY1MThFMUE0MDEzAAoJELsjr1GOGkATEWoP/j1mVMwlo0ySDYS6HgbmZ8Sc
bIh5SRmkGB7gegQaCpVyJ9lzOqai/vFkX4k1dBvD4annzrbL21gbimMG9xYnWMNQ
z/BP28tRBXGJP087agbEd3hpFm7Ei2y74cd9R3lqnMBuxCdiiQoCjcgn5fd1iR72
b5dRd/Pd0D0+LBh8L4bxEbqSwJRWS//myZuVuum+0TWNHsVCojLOYp3+yRJtr8Nm
D/k3SQUo8lI6tpAJ/33HDIhS652mkfAAeG/Ydd6lVmGfBxzfUDLfO3HeBm5Xve3w
gE6YuA9v0dy2z3ml4yRC1dqZe0LbAQCH7/jtMOg7dupjapFmLhZISYD37PaatHfG
aF4o+sxfmT/aokIJlTsTbagboifRBnl6xTt4xjpZrctwECQEcqhsbgDH9eJHETUa
JHS9rLNJ+fTF9M5mtSjR/vnwlF4j4gubVOzfFDWqZyK+S3rpzy1VXlfsHV1F69kM
bAD99/QnDk9AbFwyN5UlFKkGV81j1ax4CRlGBQM1Qptm2m36jS8hZgp9pHBM4Co8
fQgxe9sPUPCXpNe7kR/9jVqG7GUf46LdEESnxFsBzrQmYQbJCcYc5sO5IvrFkhI7
84pyKeI7/z/gD7FBzdZ+XksMS2xiJHWz8igIKVis9d6GEPkuq8qyLtyc7FL5GRQb
5XMf8Iok0jWal8yaJOAs
=rb4c
-----END PGP SIGNATURE-----
--AWEDSiaSx2aBMGNTh3bQKoD3i9FK5j1No--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56b7d3f5-56d9-26fc-da1d-be13ce32a213>