From owner-freebsd-current@FreeBSD.ORG Fri Dec 2 08:59:08 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F5AD106564A; Fri, 2 Dec 2011 08:59:08 +0000 (UTC) (envelope-from fjoe@samodelkin.net) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id E299E8FC08; Fri, 2 Dec 2011 08:59:07 +0000 (UTC) Received: by ggnk5 with SMTP id k5so4129358ggn.13 for ; Fri, 02 Dec 2011 00:59:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.88.99 with SMTP id bf3mr2114136obb.73.1322816346671; Fri, 02 Dec 2011 00:59:06 -0800 (PST) Received: by 10.182.76.225 with HTTP; Fri, 2 Dec 2011 00:59:06 -0800 (PST) X-Originating-IP: [93.92.220.178] In-Reply-To: <20111202084357.GB85770@dragon.NUXI.org> References: <20111202015537.GB4111@dragon.NUXI.org> <20111202084357.GB85770@dragon.NUXI.org> Date: Fri, 2 Dec 2011 15:59:06 +0700 Message-ID: From: Max Khon To: obrien@freebsd.org, Max Khon , freebsd-current Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: removing libreadline from base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 08:59:08 -0000 David, On Fri, Dec 2, 2011 at 3:43 PM, David O'Brien wrote: > On Fri, Dec 02, 2011 at 12:57:20PM +0700, Max Khon wrote: > > On Fri, Dec 2, 2011 at 8:55 AM, David O'Brien > wrote: > > If you go with (2) above, we'll still have *tons* of ports that want a > > > libreadline, so we'll just end up growing a port of it and we'll wind > up > > > with a libreadline on the system anyway. > > > > Then you need to define what base system is. > > Eh? Its the same definition has been for the past 17 years -- that which > is in /usr/src. > > As long as there is a GPL consumer of libreadline in /usr/src, there is > no benefit to kicking libreadline out of /usr/src. > > I understand the anti-GPL sentiment -- I've done my share over the years > to help achieve a GPL-free FreeBSD. But until there is a debugger that > is anywhere near as capable (and mature) as GDB, we'll have a few GPL > bits in /usr/src. > > I see that as OK -- its is small and contained. > One of the suggested alternatives (that looks more viable to me now because of incompatibilities between libedit and libreadline) is to have libreadline as INTERNALLIB. So that it is not exposed outside of gdb build. So that if we ever decide to replace gdb with something else in the base all we have to do is to svn rm gdb and friends. In other words, I suggest to reduce the number of dependencies on base system libreadline to just base system gdb. E.g. we do not expose expat from our base system to the outside world because we do not want to have unnecessary dependencies between base and ports. Show me a non-GPL consumer of libreadline in /usr/src and I'll do > everything I can to have it work with libedit. > > When I added the libreadline compatibility to libedit, I changed all the > non-GPL libreadline uses I knew of to libedit. > > > > We have much more ports that depend on libintl or libglib2 than > > libreadline. Should we add these libs to the base system too? > > Please tell me what consumer of libintl or libglib2 we have in /usr/src. Your sentiment was about having libreadline port/package to be installed on almost every system. We already have such packages (libintl and libglib2) so there is nothing wrong with having libreadline as a port/package and it does not imply that we should have it installed with the base system. Max