From owner-freebsd-ports@FreeBSD.ORG Mon Aug 14 14:04:17 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA39E16A4DF; Mon, 14 Aug 2006 14:04:17 +0000 (UTC) (envelope-from gslin@netnews.NCTU.edu.tw) Received: from netnews.NCTU.edu.tw (ccreader.nctu.edu.tw [140.113.54.119]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBA5643D6E; Mon, 14 Aug 2006 14:04:13 +0000 (GMT) (envelope-from gslin@netnews.NCTU.edu.tw) Received: by netnews.NCTU.edu.tw (Postfix, from userid 1000) id 0D6011F9; Mon, 14 Aug 2006 22:04:09 +0800 (CST) Date: Mon, 14 Aug 2006 22:04:08 +0800 From: Gea-Suan Lin To: Mathieu Arnold Message-ID: <20060814140408.GA91268@gslin.org> References: <200608141059.k7EAx2ro062422@freefall.freebsd.org> <20060814122602.GA86906@gslin.org> MIME-Version: 1.0 Content-Type: text/plain; charset=big5 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.12-2006-07-14 Cc: gslin@gslin.org, freebsd-ports@freebsd.org Subject: Re: ports/101840: [PATCH] ftp/p5-Net-FTPServer: Respect DESTDIR X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2006 14:04:17 -0000 Hello, On Mon, Aug 14, 2006 at 02:31:05PM +0200, Mathieu Arnold wrote: > +-le 14/08/2006 20:26 +0800, Gea-Suan Lin a dit : > | Hello, > | > | I disagree this opinion. DESTDIR should be considered previous events > | like importing SHA-256, @dirrmtry, and using USE_LDCONFIG to retire > | INSTALLS_SHLIB, ... etc. > | > | When upgrading or bug-fixing with respecting DESTDIR, the pr should > | not be splited into two parts. > | > | On Mon, Aug 14, 2006 at 10:59:02AM +0000, Mathieu Arnold wrote: > |> Synopsis: [PATCH] ftp/p5-Net-FTPServer: Respect DESTDIR > |> > |> State-Changed-From-To: open->closed > |> State-Changed-By: mat > |> State-Changed-When: Mon Aug 14 10:51:42 UTC 2006 > |> State-Changed-Why: > |> Committed in two parts, the DESTDIR, then the other things. I think that > |> when doing a DESTDIR change, you should not change anything not directly > |> related to it, to keep things simple. > |> > |> http://www.freebsd.org/cgi/query-pr.cgi?pr=101840 > > Hum, all the previous things, SHA/dirrmtry, etc were done as big sweeps > separately, not with other things in them. > Unless I don't understand what you're saying, we have the same opinion. > > -- > Mathieu Arnold What I mention is not these one-shot commits but the PRs between the time of introducing SHA256/@dirrmtry and large scale commits. Importing SHA256 checksum was in 2005/11/08. After that, there were many people sending upgrading/fixing PRs with adding SHA256 at same time. Then in 2006/1/22, all ports were done. So I think DESTDIR is same. -- * Gea-Suan Lin (public key: Using https://keyserver.pgp.com/ to search) * If you cannot convince them, confuse them. -- Harry S Truman