From owner-svn-src-head@freebsd.org Wed Nov 20 23:42:21 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9BF71C5A4C; Wed, 20 Nov 2019 23:42:21 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47JK3x42mpz4WwX; Wed, 20 Nov 2019 23:42:21 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 543078D4A15E; Wed, 20 Nov 2019 23:42:13 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 8A11CE707FD; Wed, 20 Nov 2019 23:42:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id V4TRTEip5W0n; Wed, 20 Nov 2019 23:42:10 +0000 (UTC) Received: from [192.168.2.110] (unknown [IPv6:fde9:577b:c1a9:31:a48e:25c1:a165:8cd7]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 41280E707AC; Wed, 20 Nov 2019 23:42:09 +0000 (UTC) From: "Bjoern A. Zeeb" To: "John Baldwin" Cc: "Warner Losh" , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r354900 - head/usr.sbin/jail Date: Wed, 20 Nov 2019 23:42:08 +0000 X-Mailer: MailMate (2.0BETAr6142) Message-ID: In-Reply-To: <991bdc33-516d-6e6d-1880-44930441893d@FreeBSD.org> References: <201911201654.xAKGsMTv094014@repo.freebsd.org> <59bf120c-2f35-1a22-b6fa-a9c9bb8cfdf4@FreeBSD.org> <991bdc33-516d-6e6d-1880-44930441893d@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Rspamd-Queue-Id: 47JK3x42mpz4WwX X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-0.99)[-0.994,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2019 23:42:21 -0000 On 20 Nov 2019, at 23:32, John Baldwin wrote: Hijacking a side-thread: PreS: I think we have way too many of these options and should just remove 3/4 of them again or someone build a proper matrix documenting them all and in which case to use in the developers handbook ;-) > This one also seems dubious, but in a different way: > > usr.bin/Makefile: > > # ARM64TODO gprof does not build > # RISCVTODO gprof does not build > .if ${MACHINE_ARCH} != "aarch64" && ${MACHINE_CPUARCH} != "riscv" > SUBDIR.${MK_TOOLCHAIN}+= gprof > .endif > > Somewhat exacerbated by the whole aarch64 vs arm64 thing and probably > confusion on when to use CPUARCH vs ARCH. This particular case could actually be removed as I thought I made that at least compile when I was working on s390x: https://svnweb.freebsd.org/base?view=revision&revision=351329 You can however find more of these elsewhere: ../lib/libc/tests/sys/Makefile:.if ${MACHINE_CPUARCH} != "aarch64" && ${MACHINE_CPUARCH} != "riscv" ../lib/libcompiler_rt/Makefile.inc:.if ${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_CPUARCH} == "riscv" ../stand/libsa/Makefile:.if ${MACHINE_CPUARCH} == "aarch64" || ${MACHINE_CPUARCH} == "riscv" ../usr.bin/Makefile:.if ${MACHINE_ARCH} != "aarch64" && ${MACHINE_CPUARCH} != "riscv" ../usr.bin/gprof/Makefile:.if ${MACHINE_ARCH} != "aarch64" && ${MACHINE_ARCH} != "riscv" && \