From owner-svn-ports-head@FreeBSD.ORG  Mon Jan 13 10:42:04 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3F607C54;
 Mon, 13 Jan 2014 10:42:04 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2AB1A1F02;
 Mon, 13 Jan 2014 10:42:04 +0000 (UTC)
Received: from nemysis4now (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with SMTP id s0DAg1Oe090762;
 Mon, 13 Jan 2014 10:42:02 GMT (envelope-from nemysis@FreeBSD.org)
Received: by nemysis4now (sSMTP sendmail emulation);
 Mon, 13 Jan 2014 11:42:00 +0100
Date: Mon, 13 Jan 2014 11:42:00 +0100
From: Rusmir Dusko <nemysis@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r338572 - head/games/palomino
Message-ID: <20140113104200.GA80610@nemysis4now>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jan 2014 10:42:04 -0000

> On Fri, Jan 03, 2014 at 06:59:38PM +0000, Rusmir Dusko wrote:
> > New Revision: 338572
> > URL: http://svnweb.freebsd.org/changeset/ports/338572
> > 
> > -DESKTOP_ENTRIES=	"Palomino" "${COMMENT}" "${PORTNAME}" \
> > -			"${PORTNAME}" "Game;ArcadeGame;" false
> > +DESKTOP_ENTRIES=	"Palomino" "" "${PORTNAME}" \
> > +			"${PORTNAME}" "Game;ArcadeGame;" ""  

> I've noticed you've removed "${COMMENT}" from DESKTOP_ENTRIES in some recent
> commits; could you elaborate on it a bit?  Most of the usage examples in the
> tree seem to include "${COMMENT}"...

In my earlier email correspondence with makcs regarding DESKTOP_ENTRIES,
he stated some interesting arguments, as to why would one, do so.

This is from his last email:

> I suppose you simply removed 'false', so that DESKTOP_ENTRIES had only 5 elements.
> If you need empty field, you shall use double quotes (""), e.g:

> DESKTOP_ENTRIES=	"Name" "" "Icon" "Exec" "Categories" ""

> This desktop entry will use ports ${COMMENT} for second field, and empty
> StartupNotify field.

> You may want to look description for DESKTOP_ENTRIES in Mk/bsd.port.mk.
> It covers more cases than Porters Handbook.

http://www.freebsd.org/doc/en/books/porters-handbook/using-x11.html#desktop-entries

Having that in mind, I removed "${COMMENT}" from DESKTOP_ENTRIES in some recent
commits.

-- 
Best regards,
Rusmir Dusko