From owner-freebsd-current@FreeBSD.ORG Sat May 10 22:39:06 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49F23AA5 for ; Sat, 10 May 2014 22:39:06 +0000 (UTC) Received: from mail-qg0-x230.google.com (mail-qg0-x230.google.com [IPv6:2607:f8b0:400d:c04::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 03516172 for ; Sat, 10 May 2014 22:39:05 +0000 (UTC) Received: by mail-qg0-f48.google.com with SMTP id i50so6038839qgf.7 for ; Sat, 10 May 2014 15:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=3fsuiHQZ+AGT6hCsiYTD+WKJSNT2BrobLXKERHXMzB0=; b=F7T0w4YZz9bZnnnFwX/zdEGUgQuZBicKs8F+yvpw8f0ZV+gSSPAgxmUeYG2d1XKost mB7LeLUP5pSejN6ZQ0ayHKMpmP0lsP2vPv1y+wzj+og8LIyXMGrZeyBPIZSXSFGl2kNM NwxEeYVSM++KsCzes8r6LkJWElq/WYqWQ7MYPMn1OoqgKMTX0HzWOERZSrjaPwoVkYpK 9jd1iR0buLKTg57S7bb0Nc6kDHyXKLrnaHnCADuk8XLs0Ve8G1YGGa6KcQ1pfYwx3k3p CUZrILpWVk8+0c3QNU6o1xSCezqD/2AEcg5wW1Gfp4BonSzHlXZrno3siACN0a6xpZHS zxGA== X-Received: by 10.224.112.74 with SMTP id v10mr26295364qap.28.1399761544330; Sat, 10 May 2014 15:39:04 -0700 (PDT) Received: from pwnie.vrt.sourcefire.com (moist.vrt.sourcefire.com. [198.148.79.134]) by mx.google.com with ESMTPSA id t14sm4132419qge.33.2014.05.10.15.39.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 May 2014 15:39:03 -0700 (PDT) Date: Sat, 10 May 2014 18:39:01 -0400 From: Shawn Webb To: Warner Losh Subject: Re: Recent Changes to WITH_*/WITHOUT_* in src Message-ID: <20140510223901.GV3063@pwnie.vrt.sourcefire.com> References: <20140510164512.GS3063@pwnie.vrt.sourcefire.com> <73589111-84D9-40EA-89F1-330396E853DA@bsdimp.com> <20140510212531.GT3063@pwnie.vrt.sourcefire.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GTZ+2qEBTXdGs1w1" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 May 2014 22:39:06 -0000 --GTZ+2qEBTXdGs1w1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On May 10, 2014 03:29 PM -0600, Warner Losh wrote: >=20 > On May 10, 2014, at 3:25 PM, Shawn Webb wrote: >=20 > > On May 10, 2014 02:14 PM -0600, Warner Losh wrote: > >>=20 > >> On May 10, 2014, at 10:45 AM, Shawn Webb wrote: > >>=20 > >>> Hey All, > >>>=20 > >>> It seems that the recent changes to the makefiles for building > >>> world/kernel have broken some modifications I have locally for > >>> implementing ASLR+PIE. I'm quite the bsd make newbie, so I thought I'd > >>> ask for a bit of help. I'm sure the solution is quite simple. > >>>=20 > >>> My code is up on GitHub. I'll include links at the bottom of the emai= l. > >>>=20 > >>> The code in question is in share/mk/bsd.prog.mk, where I'm checking to > >>> see if MK_PIE is not equal to "no". Prior to the recent changes, this > >>> code used to work. (Please note that I know that the way I'm cheking = is > >>> a bit bloated, if anyone has any suggestions to trim my code down, let > >>> me know). > >>=20 > >> You?ll need to add PIE to DEFAULT_NO_OPTIONS in bsd.opts.mk since > >> bsd.*.mk files need it. > >>=20 > >=20 > > Thanks a lot! Adding it to that one worked. > >=20 > > But what's the difference between the DEFAULT_NO_OPTIONS in src.opts.mk= and > > bsd.opts.mk? >=20 > Options to build FreeBSD?s /usr/src are defined in src.opts.mk. Options t= ested by bsd.*.mk, which can be used to build other things, are in bsd.opts= =2Emk.=20 Cool. Thanks for the clarification. Do the options tested by bsd.opts.mk get parsed by the ports framework? I've added similar functionality to the ports framework, but maybe I can remove it in favor of bsd.opts.mk + bsd.prog.mk? Thanks, Shawn --GTZ+2qEBTXdGs1w1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTbqmBAAoJEGqEZY9SRW7uNqEQAL7EvpGh41a6Z+l7accUhC5j KIo1bKe6xt8cTBpY/NJ9J7hGiqVxQl9TVGIAk6RpbhMLYqWkMsi0aZmSZ+XoIekp PKhQouARUXu88MQPu9lL75vQrVYT04e2llYQ7jpV6qOfn2pNEWM1EeoXpmuED9rP LX6pgDIKeWEth0Y0EAxlikZ4rH/tq6H1L7526SNFpPp7g6XQsgEETZpabSvgrsNn K5b2MrO1s1XrNiADeofgzOZ6uGktJWAI8skL534hQVLl6n0bHZyAWcbhCQJS9LM5 Q2J+e9CFRYU58T9aUXkG7LJHr1m/YIkahEC1lUqsLr/tk/qTvCb3A+r6jjVcvYOr msUeATmhktxXxs12rgzPbk54U0RF9cLMV9Zjp/uyzoWsObbbQgocaV15nmlUlFAc YdFuQoL3k/w+saVFYz8SnXqJSWect6j4MZ5U7gL/0vzvG7FJvePPUvot0icYkXfp apUOSedgrePkuNDP1xlHbJ+v87sQo1MozYm31uCOrPtSOlz7UAe9pjZ5mBDuJT9r GYPL4yjNQHUCbXShgoa0DRh7zW9zJ7Mo2q9a6WmqtL2133+t6fkWTIomH17f+luV Jhnp5lrm7S7uG6BvxQqHyFYBbitNT7Hn6A5j8QpRhImML0NNT+O/iM9Nm49yIKFI N1d65300O6osxRlS4sVq =DGnb -----END PGP SIGNATURE----- --GTZ+2qEBTXdGs1w1--