From owner-svn-ports-all@freebsd.org Mon Jan 2 15:08:14 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3863FC9B3E7; Mon, 2 Jan 2017 15:08:14 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp.infracaninophile.co.uk [IPv6:2001:8b0:151:1:c4ea:bd49:619b:6cb3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.infracaninophile.co.uk", Issuer "infracaninophile.co.uk" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BE76713A2; Mon, 2 Jan 2017 15:08:13 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from liminal.local (unknown [IPv6:2001:8b0:151:1:1c1d:86a1:a200:b700]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: m.seaman@infracaninophile.co.uk) by smtp.infracaninophile.co.uk (Postfix) with ESMTPSA id B01CC937B; Mon, 2 Jan 2017 15:08:10 +0000 (UTC) Authentication-Results: smtp.infracaninophile.co.uk; dmarc=none header.from=FreeBSD.org Authentication-Results: smtp.infracaninophile.co.uk/B01CC937B; dkim=none; dkim-atps=neutral Subject: Re: svn commit: r430355 - in head/lang: erlang erlang-runtime19 To: Jimmy Olgeni , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201701021324.v02DOkom002681@repo.freebsd.org> From: Matthew Seaman Message-ID: <56b7d3f5-56d9-26fc-da1d-be13ce32a213@FreeBSD.org> Date: Mon, 2 Jan 2017 15:08:10 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <201701021324.v02DOkom002681@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AWEDSiaSx2aBMGNTh3bQKoD3i9FK5j1No" X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,RDNS_NONE, SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on smtp.infracaninophile.co.uk X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2017 15:08:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AWEDSiaSx2aBMGNTh3bQKoD3i9FK5j1No Content-Type: multipart/mixed; boundary="VLKQUiRlumo5CnR4icbHmc0ugau0ghoeE"; protected-headers="v1" From: Matthew Seaman To: Jimmy Olgeni , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <56b7d3f5-56d9-26fc-da1d-be13ce32a213@FreeBSD.org> Subject: Re: svn commit: r430355 - in head/lang: erlang erlang-runtime19 References: <201701021324.v02DOkom002681@repo.freebsd.org> In-Reply-To: <201701021324.v02DOkom002681@repo.freebsd.org> --VLKQUiRlumo5CnR4icbHmc0ugau0ghoeE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/01/2017 13:24, Jimmy Olgeni wrote: > +.if !exists(/usr/sbin/dtrace) > +OPTIONS_EXCLUDE+=3D DTRACE > +.endif > + > +OPTIONS_EXCLUDE_FreeBSD_9=3D DTRACE > +OPTIONS_EXCLUDE_FreeBSD_10=3D DTRACE > +OPTIONS_EXCLUDE_i386=3D DTRACE > + I am not sure that the way you have enabled DTRACE by default makes much sense. I investigated building ports via poudriere with DTRACE enabled a little while back and I found * poudriere jails need a copy of the host systems' kernel -- never mind if that is a different OS version than what the jail is using. * It's impossible to build successfully with enabled DTRACE when crossbulding for i386 on a host system running amd64. I've a pull request here: https://github.com/freebsd/poudriere/pull/410 to add a capability to null-mount the host system kernel into poudriere jails which allows building with DTRACE enabled for 9 and 10 on an 11 hos= t. However, I suspect that most of these problems are artifacts of the way poudriere uses jails to build for the various OS versions etc. Building /natively/ on any of the combinations of OS and architecture might very well work. My recommendation would be to either leave DTRACE support present for all OS/arch combinations, but disabled by default. Or to automatically disable DTRACE if building under poudriere can be detected. Which means unfortunately that precompiled pkgs wouldn't have DTRACE support enabled.= Cheers, Matthew --VLKQUiRlumo5CnR4icbHmc0ugau0ghoeE-- --AWEDSiaSx2aBMGNTh3bQKoD3i9FK5j1No Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJYamzaXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NTNBNjhCOTEzQTRFNkNGM0UxRTEzMjZC QjIzQUY1MThFMUE0MDEzAAoJELsjr1GOGkATEWoP/j1mVMwlo0ySDYS6HgbmZ8Sc bIh5SRmkGB7gegQaCpVyJ9lzOqai/vFkX4k1dBvD4annzrbL21gbimMG9xYnWMNQ z/BP28tRBXGJP087agbEd3hpFm7Ei2y74cd9R3lqnMBuxCdiiQoCjcgn5fd1iR72 b5dRd/Pd0D0+LBh8L4bxEbqSwJRWS//myZuVuum+0TWNHsVCojLOYp3+yRJtr8Nm D/k3SQUo8lI6tpAJ/33HDIhS652mkfAAeG/Ydd6lVmGfBxzfUDLfO3HeBm5Xve3w gE6YuA9v0dy2z3ml4yRC1dqZe0LbAQCH7/jtMOg7dupjapFmLhZISYD37PaatHfG aF4o+sxfmT/aokIJlTsTbagboifRBnl6xTt4xjpZrctwECQEcqhsbgDH9eJHETUa JHS9rLNJ+fTF9M5mtSjR/vnwlF4j4gubVOzfFDWqZyK+S3rpzy1VXlfsHV1F69kM bAD99/QnDk9AbFwyN5UlFKkGV81j1ax4CRlGBQM1Qptm2m36jS8hZgp9pHBM4Co8 fQgxe9sPUPCXpNe7kR/9jVqG7GUf46LdEESnxFsBzrQmYQbJCcYc5sO5IvrFkhI7 84pyKeI7/z/gD7FBzdZ+XksMS2xiJHWz8igIKVis9d6GEPkuq8qyLtyc7FL5GRQb 5XMf8Iok0jWal8yaJOAs =rb4c -----END PGP SIGNATURE----- --AWEDSiaSx2aBMGNTh3bQKoD3i9FK5j1No--