Date: Thu, 4 Sep 2008 18:20:02 GMT From: Bruce Cran <bruce@cran.org.uk> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/71667: [PATCH] cleanup of the usr.sbin/bootparamd code Message-ID: <200809041820.m84IK2LR036787@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/71667; it has been noted by GNATS.
From: Bruce Cran <bruce@cran.org.uk>
To: bug-followup@FreeBSD.org, dan@obluda.cz
Cc:
Subject: Re: bin/71667: [PATCH] cleanup of the usr.sbin/bootparamd code
Date: Thu, 4 Sep 2008 19:10:13 +0100
--MP_/dwsL/WnOOCR.BtgJirF=O2V
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
The bootparamd code needs quite a few more changes to make it compile
with WARNS=6 with GCC 4. I've attached a patch for
callbootd/callbootd.c, but changes are also needed for
bootparamd/bootparamd.c
--
Bruce Cran
--MP_/dwsL/WnOOCR.BtgJirF=O2V
Content-Type: text/x-patch; name=callbootd.c.diff
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=callbootd.c.diff
--- callbootd.c.orig 2008-09-04 18:48:40.000000000 +0100
+++ callbootd.c 2008-09-04 18:57:11.000000000 +0100
@@ -32,15 +32,14 @@
char cln[MAX_MACHINE_NAME+1];
char dmn[MAX_MACHINE_NAME+1];
char path[MAX_PATH_LEN+1];
-extern char *inet_ntoa();
static void usage(void);
int printgetfile(bp_getfile_res *);
int printwhoami(bp_whoami_res *);
+bool_t eachres_whoami(bp_whoami_res *, struct sockaddr_in *);
+bool_t eachres_getfile(bp_getfile_res *, struct sockaddr_in *);
bool_t
-eachres_whoami(resultp, raddr)
-bp_whoami_res *resultp;
-struct sockaddr_in *raddr;
+eachres_whoami(bp_whoami_res *resultp, struct sockaddr_in *raddr)
{
struct hostent *he;
@@ -52,9 +51,7 @@
}
bool_t
-eachres_getfile(resultp, raddr)
-bp_getfile_res *resultp;
-struct sockaddr_in *raddr;
+eachres_getfile(bp_getfile_res *resultp, struct sockaddr_in *raddr)
{
struct hostent *he;
@@ -67,9 +64,7 @@
int
-main(argc, argv)
-int argc;
-char **argv;
+main(int argc, char **argv)
{
char *server;
@@ -80,7 +75,7 @@
long the_inet_addr;
- CLIENT *clnt;
+ CLIENT *clnt = NULL;
enum clnt_stat clnt_stat;
stat_whoami_res.client_name = cln;
@@ -155,6 +150,7 @@
usage();
}
+ return 0;
}
--MP_/dwsL/WnOOCR.BtgJirF=O2V--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809041820.m84IK2LR036787>