Date: Wed, 22 Nov 2017 20:41:41 -0800 From: Mark Millard <markmi@dsl-only.net> To: Bryan Drewery <bdrewery@FreeBSD.org>, FreeBSD Ports <freebsd-ports@freebsd.org> Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org> Subject: Re: poudriere-devel -S SRCPATH : no longer supported? (/usr/ports/ -r454407 vintage example) Message-ID: <812FE2F6-A094-49A6-89A3-BE01EE3E1FF3@dsl-only.net> In-Reply-To: <39DB21B0-F31B-4B64-8A53-74EB46D5DB0C@dsl-only.net> References: <39DB21B0-F31B-4B64-8A53-74EB46D5DB0C@dsl-only.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[Dumb typo in my } placements.]
On 2017-Nov-22, at 8:36 PM, Mark Millard <markmi at dsl-only.net> wrote:
> As evidence only two lines of jail.sh reference SRCPATH
> other than where -S assigns to it:
>
> # grep "SRCPATH" /usr/local/share/poudriere/jail.sh
> [ -z "${SRCPATH}" ] && DISTS="${DISTS} src"
> [ -n "$SRCPATH" ] && jset ${JAILNAME} srcpath ${SRCPATH}
> SRCPATH=${OPTARG}
>
> Also, every non-comment instance of /usr/src in jail.sh
> is preceded by just ${JAILMNT} or ${SRC_BASE} or by
> nothing:
>
> # grep "\/usr\/src" /usr/local/share/poudriere/jail.sh | more
> SRC_BASE="${JAILMNT}/usr/src"
> export SRC_BASE=${JAILMNT}/usr/src
> # Otherwise it's the older broken one, so use the host /usr/src
> : ${XDEV_SRC:=/usr/src}
> msg_n "Copying ${SRC_BASE} to ${JAILMNT}/usr/src..."
> mkdir -p ${JAILMNT}/usr/src
> if [ -f ${SRC_BASE}/usr/src/.cpignore ]; then
> cpdup -i0 ${cpignore_flag} ${SRC_BASE} ${JAILMNT}/usr/src
> SRC_BASE="${JAILMNT}/usr/src"
>
>
> It leaves me wondering if some notation like:
>
> ${SRCPATH:-${JAILMNT}}/usr/src
${SRCPATH:-${JAILMNT}/usr/src}
> should be in use in some places where
>
> ${JAILMNT}/usr/src
>
> is now in use. I'm no so sure that the
> analogous is appropriate for the one
> example of :
>
> ${SRC_BASE}/usr/src
===
Mark Millard
markmi at dsl-only.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?812FE2F6-A094-49A6-89A3-BE01EE3E1FF3>