From nobody Wed Feb 8 18:29:27 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PBpS80DYNz3nlnc; Wed, 8 Feb 2023 18:29:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PBpS761cqz3w3K; Wed, 8 Feb 2023 18:29:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675880967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yUp+aKpqDJxfoDY+8AJk/2ZvL1OvTcBtO6dxaDVIacc=; b=cpGLsHD60Sic8J1Ybmfji1XN8ZFfdtGprZuyfVU+03jJkUudSjJUjXMKniwjlfxhU1CH8d PZb9O5zKaW3ugeJS+Z+1+OLCWBuBhCB3BglBpqNflpBE6A1m0W5T1cHd79wYVQAcV3LmIz D3CDN2nosaHA0PuocsfpsYYZsxDm4952bra/lCqX75pnPXiueadEDMcQbAn353tgfjKIF4 fxOCXOg9I+jq142AOq/FLt8VkdeVuvBSvNSmFgzqf9DeSjGWpgWVrjTQSn3zNl1QtrbQ5A KxnWzWRWdD4oLUrL3ScaYs/BAvSmw0z6GYDLELrrYvBVd4lDibSb5xI6gvmpsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675880967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yUp+aKpqDJxfoDY+8AJk/2ZvL1OvTcBtO6dxaDVIacc=; b=Iq2EaQHJx3PHf0JxdD4xrqSg7gnUj0ferOY2o0nlOiHeLzudVAgJ49jZAq7ig5R1HXnm1f /nU6wMbgA2iDq14IGbC6E2UHPfRTvVvV5Rz7jseFnYyq9o4ObdRbRLkz8FYCRnr1Ed8nMI TZNNqBGSUWOR7FvymHdPDz0jw6fcQIQObKItGp+XHryCzDwqG3xwy+Tl0wLA6iaJ7+CP51 9BHRVxnaiFPdHdLAh42EuY8Gl1o6fSKTwrlvRPla3LQCNIUf51zIwumuFX+G+gOHAeF5i5 YueaTBGmXMoljMj0Lx2YzLW+RBLF8APzsmYvnXaItcTAa1Pmpocog21v6zHT3Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675880967; a=rsa-sha256; cv=none; b=FtKbxOXwHxoCYBzyVkPzU6Mw8HxCZQ6C60pZdM6+VJV1T5cJfgi4fEplWNsCfE9HbL4RaG yTJU6IOkx2mPgbvYq/M7naEa8yx36RFp9+MwawKGnm0bMEAHaLN4o8v7SWPqZuS2zZNr8z 09gHwSIiyNCFQx7UI3qbR6IgUWFAlo+o0KDcb8mjsh9qGDV1YpFccFPrG68CCFc6x/0yrH OTRRohBvmMc2TFBREj+YjGHVhJEdegnRsrIjMSpa+Jr8TB7Vq5KdMudb28cJehYgUaRv4K /THptTcN3ZqXSGKoNIdTzyKfufvXcunDrMSTT+hAxjKcXkhy9FADHOD073TQ1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PBpS752xYz16bS; Wed, 8 Feb 2023 18:29:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 318ITRNm037465; Wed, 8 Feb 2023 18:29:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 318ITRjZ037464; Wed, 8 Feb 2023 18:29:27 GMT (envelope-from git) Date: Wed, 8 Feb 2023 18:29:27 GMT Message-Id: <202302081829.318ITRjZ037464@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gordon Tetlow Subject: git: 36a39f0cc68f - releng/12.4 - ixgbe: workaround errata about UDP frames with zero checksum List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/releng/12.4 X-Git-Reftype: branch X-Git-Commit: 36a39f0cc68fab01d2c33f4738e865664db31192 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch releng/12.4 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=36a39f0cc68fab01d2c33f4738e865664db31192 commit 36a39f0cc68fab01d2c33f4738e865664db31192 Author: Andrey V. Elsukov AuthorDate: 2022-11-10 09:34:40 +0000 Commit: Gordon Tetlow CommitDate: 2023-02-08 16:32:02 +0000 ixgbe: workaround errata about UDP frames with zero checksum Intel 82599 has errata related to IPv4 UDP frames with zero checksum. It reports such datagrams with L4 integrity errors in IXGBE_XEC register. And after afb1aa4e6df2 commit such errors are reported via IFCOUNTER_IERRORS. This confuses users, since actually all frames are handled correctly by the system. To workaround the problem, let's ignore the XEC register value for 82599 cards for now. PR: 266048 Discussed with: erj Sponsored by: Yandex LLC Approved by: so Security: FreeBSD-EN-23:04.ixgbe (cherry picked from commit 8526120ad41ca47367b43f8f4459e0fa61285571) (cherry picked from commit fe9c4deda9d4aa2c5bed75071f8006bd2a0734a2) --- sys/dev/ixgbe/if_ix.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index a361645d3b9f..47f3918fd8ee 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1574,8 +1574,12 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) * - fragmented packets count, * - oversized packets count, * - jabber count. + * + * Ignore XEC errors for 82599 to workaround errata about + * UDP frames with zero checksum. */ - IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + stats->xec + + IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + + (hw->mac.type != ixgbe_mac_82599EB ? stats->xec : 0) + stats->mpc[0] + stats->rlec + stats->ruc + stats->rfc + stats->roc + stats->rjc); } /* ixgbe_update_stats_counters */