From owner-svn-src-all@FreeBSD.ORG Tue Mar 3 19:38:57 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3CE45106564A; Tue, 3 Mar 2009 19:38:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 2B40C8FC14; Tue, 3 Mar 2009 19:38:57 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n23Jcugm019695; Tue, 3 Mar 2009 19:38:56 GMT (envelope-from bz@svn.freebsd.org) Received: (from bz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n23Jcur7019694; Tue, 3 Mar 2009 19:38:56 GMT (envelope-from bz@svn.freebsd.org) Message-Id: <200903031938.n23Jcur7019694@svn.freebsd.org> From: "Bjoern A. Zeeb" Date: Tue, 3 Mar 2009 19:38:56 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r189320 - head/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2009 19:38:57 -0000 Author: bz Date: Tue Mar 3 19:38:56 2009 New Revision: 189320 URL: http://svn.freebsd.org/changeset/base/189320 Log: For the moment disable the VIMAGE_CTASSERTs as people have trouble while developing and compiling with kernel options that change the size of at least one structure. The current kernel build framework does not allow us to pass -Dxxx to module builds so we would possibly need a kernel option to disable the checks and that might not work for people just building modules alone. For now they helped to identify possibly API problems and bring those back into minds of developers seeking for better solutions. Problems reported by: kib, warner Reviewed by: warner Modified: head/sys/sys/vimage.h Modified: head/sys/sys/vimage.h ============================================================================== --- head/sys/sys/vimage.h Tue Mar 3 19:22:24 2009 (r189319) +++ head/sys/sys/vimage.h Tue Mar 3 19:38:56 2009 (r189320) @@ -224,6 +224,7 @@ void vnet_mod_register(const struct vnet * But as CTASSERT_EQUAL() needs special compile time options, we * want the default case to be backed by CTASSERT(). */ +#if 0 #ifndef VIMAGE_CTASSERT #ifdef VIMAGE_CHECK_SIZES #define VIMAGE_CTASSERT(x, y) \ @@ -234,5 +235,8 @@ void vnet_mod_register(const struct vnet CTASSERT(x == 0 || x == y) #endif #endif +#else +#define VIMAGE_CTASSERT(x, y) struct __hack +#endif #endif /* !_SYS_VIMAGE_H_ */