From owner-p4-projects@FreeBSD.ORG Thu Sep 27 19:30:23 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 49D8316A46E; Thu, 27 Sep 2007 19:30:23 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1DA916A46B for ; Thu, 27 Sep 2007 19:30:22 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.178]) by mx1.freebsd.org (Postfix) with ESMTP id A2D9D13C4A3 for ; Thu, 27 Sep 2007 19:30:22 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so3356185waf for ; Thu, 27 Sep 2007 12:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=jYcf/SQoiGKRZWaXpvmHbZ5wkwFFc2HGuakytVl6LfM=; b=e65AijVYjse7f/4iqO2uDrIoKphhZX74oIXfCAHNo697schTE3iDglJjE19qd4LUbbgaIoF1wBpsH8FZFK3QTq1HJdlfSHWEgnJzS85h2Wu2g7OGLl0hzisSRV88OD9oEVpbPrAQ5VZdlJyHoCNOMrB7W+7Nsf5OKqq7A083TVE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lCUq2d1PAUb+Ui69JdbGNVUuKCg6FnAJxSh1SZp+a5kyfWNBYVv/WxC1EcO67wOOiuzpyjppOWAysyjP8HND6XsySS9uLBqndJuEa/v2pvXFGOMCNlBq76rfIcRQtNx+eVlQqAR7d3kJ2gRIkSb+1uTE2wqGxTvFvY/hB3alLZU= Received: by 10.114.95.1 with SMTP id s1mr2895114wab.1190921422036; Thu, 27 Sep 2007 12:30:22 -0700 (PDT) Received: by 10.114.13.15 with HTTP; Thu, 27 Sep 2007 12:30:22 -0700 (PDT) Message-ID: Date: Thu, 27 Sep 2007 12:30:22 -0700 From: "Kip Macy" To: "John Baldwin" In-Reply-To: <200709271528.48811.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200709262040.l8QKe8FL074297@repoman.freebsd.org> <200709261742.04531.jhb@freebsd.org> <200709271528.48811.jhb@freebsd.org> Cc: Perforce Change Reviews , Kip Macy Subject: Re: PERFORCE change 126835 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2007 19:30:23 -0000 On 9/27/07, John Baldwin wrote: > On Thursday 27 September 2007 03:18:10 pm Kip Macy wrote: > > It is in there, it just doesn't seem to do the trick :-/. > > Note that there was a recent bug fix in HEAD that fixed a race where if you > were using a callout that rescheduled itself and didn't do an explicit > callout_stop() while holding the lock but just did a callout_drain(), then > the callout could remain scheduled. The latest commit to kern_timeout.c > should fix this though. That would explain what I was seeing. -Kip > > -Kip > > > > On 9/26/07, John Baldwin wrote: > > > On Wednesday 26 September 2007 04:40:08 pm Kip Macy wrote: > > > > http://perforce.freebsd.org/chv.cgi?CH=126835 > > > > > > > > Change 126835 by kmacy@kmacy_home:ethng on 2007/09/26 20:40:03 > > > > > > > > increase delay in shutdown to avoid destroying the port lock > > > > before the last call to the tick handler > > > > > > > > Affected files ... > > > > > > > > .. //depot/projects/ethng/src/sys/dev/cxgb/cxgb_main.c#21 edit > > > > > > > > Differences ... > > > > > > > > ==== //depot/projects/ethng/src/sys/dev/cxgb/cxgb_main.c#21 (text+ko) > ==== > > > > > > > > @@ -1023,7 +1023,7 @@ > > > > > > > > ether_ifdetach(p->ifp); > > > > printf("waiting for callout to stop ..."); > > > > - DELAY(10000); > > > > + DELAY(100000); > > > > printf("done\n"); > > > > > > Umm, what about callout_drain()? That's its purpose. > > > > > > -- > > > John Baldwin > > > > > > > > > -- > John Baldwin >