From owner-freebsd-current  Sat May 18 16:41:49 2002
Delivered-To: freebsd-current@freebsd.org
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by hub.freebsd.org (Postfix) with SMTP id 204C237B40B
	for <freebsd-current@freebsd.org>; Sat, 18 May 2002 16:41:47 -0700 (PDT)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa04845@salmon>; 19 May 2002 00:41:46 +0100 (BST)
To: Terry Lambert <tlambert2@mindspring.com>
Cc: Ian <freebsd@damnhippie.dyndns.org>,
	freebsd-current <freebsd-current@freebsd.org>
Subject: Re: df 
In-Reply-To: Your message of "Sat, 18 May 2002 16:12:45 PDT."
             <3CE6DFED.8604C72C@mindspring.com> 
Date: Sun, 19 May 2002 00:41:44 +0100
From: Ian Dowse <iedowse@maths.tcd.ie>
Message-ID:  <200205190041.aa04845@salmon.maths.tcd.ie>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In message <3CE6DFED.8604C72C@mindspring.com>, Terry Lambert writes:
>I think the reason for the "if" is to keep the df from hanging
>indefinitely, particularly when you give it an explicit list.

No, I believe the "if (vfslist != NULL)" code was there to reduce
the maximum column widths to those necessary for an explicit list
of filesystems rather than using the maximum widths for all
filesystems. The regetmntinfo() call before the "if" has already
performed any operations that could hang indefinitely, so it makes
sense to unconditionally use these up-to-date results instead of
the potentially stale list from getmntinfo(..., MNT_NOWAIT).

Ian

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message