From owner-svn-src-all@FreeBSD.ORG Wed Oct 15 09:21:52 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 465E23AE; Wed, 15 Oct 2014 09:21:52 +0000 (UTC) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 039788C4; Wed, 15 Oct 2014 09:21:51 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id 045E8CDEC; Wed, 15 Oct 2014 09:21:51 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id 1E5AB4FA6; Wed, 15 Oct 2014 11:21:52 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Ed Maste Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <20141015030455.GC73266@FreeBSD.org> Date: Wed, 15 Oct 2014 11:21:52 +0200 In-Reply-To: (Ed Maste's message of "Tue, 14 Oct 2014 23:38:23 -0400") Message-ID: <86wq81y9fz.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: src-committers , svn-src-all , "George V. Neville-Neil" , Gleb Smirnoff , Olivier =?utf-8?Q?Cochard-Labb?= =?utf-8?Q?=C3=A9?= , svn-src-head X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Oct 2014 09:21:52 -0000 Ed Maste writes: > murmur3's size argument is bytes, not uint32_ts, so the test is only > hashing the first 1/4 of the keys. That's my fault, and I'm going to change it, because it's illogical. The function works on aligned arrays of int32s and should take a count, not a size. I just didn't want to delay the patch even further. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no