Date: Mon, 16 Jan 2023 19:06:20 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 268795] x11/mate-panel: fix build with clang 15 Message-ID: <bug-268795-6497-8XXOqSyTk2@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-268795-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-268795-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268795 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dca9de74ce4b13b979ea5f24c88c111a= 2f9b24dfa commit ca9de74ce4b13b979ea5f24c88c111a2f9b24dfa Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2023-01-07 00:28:09 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2023-01-16 19:04:46 +0000 x11/mate-panel: fix build with clang 15 During an exp-run for llvm 15 (see bug 265425), it turned out that x11/mate-panel failed to build with clang 15: clock-location.c:454:22: error: incompatible pointer to integer conversion assigning to 'glong' (aka 'long') from 'char *(int, int)' [-Wint-conversion] sys_timezone =3D timezone; ^ ~~~~~~~~ clock-location.c:462:24: error: incompatible pointer to integer conversion assigning to 'glong' (aka 'long') from 'char *(int, int)' [-Wint-conversion] local_timezone =3D timezone; ^ ~~~~~~~~ This is because 'timezone' as a global external variable does not exist on FreeBSD: it is a glibc-ism. Use struct tm's tm_gmtoff field instead, which has its sign reversed from the glibc global. There is also no need to manually account for DST, as tm_gmtoff includes that. PR: 268795 Approved by: portmgr (tcberner) MFH: 2023Q1 .../patch-applets_clock_clock-location.c (new) | 30 ++++++++++++++++++= ++++ 1 file changed, 30 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-268795-6497-8XXOqSyTk2>