From owner-freebsd-fs@FreeBSD.ORG Fri Aug 29 21:05:41 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D5BBE2BE for ; Fri, 29 Aug 2014 21:05:41 +0000 (UTC) Received: from mail-la0-x231.google.com (mail-la0-x231.google.com [IPv6:2a00:1450:4010:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5FE8A1897 for ; Fri, 29 Aug 2014 21:05:41 +0000 (UTC) Received: by mail-la0-f49.google.com with SMTP id b17so3297278lan.8 for ; Fri, 29 Aug 2014 14:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=MJ2WGWIKAcZsvD33u8mdbP6ylqdAWGA/BDMPRgBxmXE=; b=vkXnRi2CgIzo2Tw/C6yjhMtOOoGdbMCOkDQ7seDDBIqtwRqnv9MgAnfTj9U8yT5pXc MVvgrU2gor33VRvsCYFs68RcVKqj4nRBrid+RRonFh01pErtuECPbO5tEDA0aF5H0Nkc q5J36TjxsEICwxhmprBsROqEKGF72u7Co26Ct0001JB0OgT8o5OQp+TZY7zP0WxNCTHN 7ZL14kOD+CZrQlcRtJdnzieFIt4FjJWTXaCHd9CFdPxjrtVvcCOeCcHrVYtEeIGWuwtk PjNgg+C5U9q2cnIgHlo4b8CnNc1B8wlnODslRPJIl9YWW60iQu16A07BzAJuqCZCG8Wa RkWA== X-Received: by 10.152.5.66 with SMTP id q2mr13596758laq.11.1409346339223; Fri, 29 Aug 2014 14:05:39 -0700 (PDT) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.25.149.205 with HTTP; Fri, 29 Aug 2014 14:04:59 -0700 (PDT) In-Reply-To: <87mwant3kw.wl%berend@pobox.com> References: <87mwant3kw.wl%berend@pobox.com> From: Ivan Voras Date: Fri, 29 Aug 2014 23:04:59 +0200 X-Google-Sender-Auth: hwNh3VoPvf_2CEaRDTW7gCymISQ Message-ID: Subject: Re: lockf(1) and NFS To: Berend de Boer Content-Type: text/plain; charset=UTF-8 Cc: freebsd-fs X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2014 21:05:41 -0000 On 29 August 2014 22:59, Berend de Boer wrote: >>>>>> "Ivan" == Ivan Voras writes: > > Ivan> I've tested the following patch and it works. Any > Ivan> objections to committing it? > > That may fix some of the problems I have with NFSv4 (so still using NFSv3)! Could be... but are you sure? This is a patch to the lockf utility, not to libc or the kernel...? I do think that if lockf has this problem there has to be other code which also has it, but I've found that Linux's NFSv4 implementation does exactly the same thing so most open-source programs should already be fixed because Linux requires it also.