From owner-freebsd-bugs@FreeBSD.ORG  Mon Apr 30 19:30:09 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EF8A71065673
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 30 Apr 2012 19:30:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id A4BEC8FC0C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 30 Apr 2012 19:30:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3UJU9CM026792
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 30 Apr 2012 19:30:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3UJU9HY026789;
	Mon, 30 Apr 2012 19:30:09 GMT (envelope-from gnats)
Resent-Date: Mon, 30 Apr 2012 19:30:09 GMT
Resent-Message-Id: <201204301930.q3UJU9HY026789@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Sean Bruno <sbruno@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A4D08106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 30 Apr 2012 19:26:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 90B508FC14
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 30 Apr 2012 19:26:11 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3UJQBe1093372
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 30 Apr 2012 19:26:11 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q3UJQBF6093371;
	Mon, 30 Apr 2012 19:26:11 GMT (envelope-from nobody)
Message-Id: <201204301926.q3UJQBF6093371@red.freebsd.org>
Date: Mon, 30 Apr 2012 19:26:11 GMT
From: Sean Bruno <sbruno@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/167460: devel/libytnef: bad handling of PT_CLSID in
	TNEFFillMapi
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 19:30:10 -0000


>Number:         167460
>Category:       misc
>Synopsis:       devel/libytnef: bad handling of PT_CLSID in TNEFFillMapi
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 30 19:30:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Sean Bruno
>Release:        9-stable
>Organization:
FreeBSD 
>Environment:
FreeBSD powernoodle-l7 9.0-STABLE FreeBSD 9.0-STABLE #0 r233925: Thu Apr  5 11:34:25 PDT 2012     root@pcbsd-4855:/usr/obj/usr/home/sbruno/bsd/9/sys/GENERIC  amd64

>Description:
devel/libytnef/ytnef.c has incomplete handling of the PT_CLSID type and will spin off and crash applications attempting to use it.

Patch attached properly handles the GUID data structure via hardcoded magic values.

Fix ideas were liberally stolen from the MSDN docs and wine.org handling code.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: