From owner-freebsd-ports-bugs Wed Mar 5 15: 0:31 2003 Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DA3537B401 for ; Wed, 5 Mar 2003 15:00:28 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A607843FBF for ; Wed, 5 Mar 2003 15:00:27 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h25N0RNS092429 for ; Wed, 5 Mar 2003 15:00:27 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h25N0RO6092427; Wed, 5 Mar 2003 15:00:27 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E369637B401 for ; Wed, 5 Mar 2003 14:56:18 -0800 (PST) Received: from heechee.tobez.org (heechee.tobez.org [213.237.10.254]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FAA143FBD for ; Wed, 5 Mar 2003 14:56:18 -0800 (PST) (envelope-from tobez@tobez.org) Received: by heechee.tobez.org (Postfix, from userid 1001) id 0F5B82C7096; Wed, 5 Mar 2003 23:56:14 +0100 (CET) Message-Id: <20030305225614.0F5B82C7096@heechee.tobez.org> Date: Wed, 5 Mar 2003 23:56:14 +0100 (CET) From: Anton Berezin Reply-To: Anton Berezin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/48960: An alternative solution for perllocal.pod files Sender: owner-freebsd-ports-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 48960 >Category: ports >Synopsis: An alternative solution for perllocal.pod files >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Mar 05 15:00:27 PST 2003 >Closed-Date: >Last-Modified: >Originator: Anton Berezin >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: System: FreeBSD heechee.tobez.org 4.7-STABLE FreeBSD 4.7-STABLE #0: Sat Jan 25 21:10:24 CET 2003 tobez@heechee.tobez.org:/usr/home/tobez/src/FreeBSD/RELENG_4/obj/usr/home/tobez/src/FreeBSD/RELENG_4/src/sys/HEECHEE i386 >Description: Quoting a mail from ports@: On Thu, Feb 20, 2003 at 06:22:38PM -0800, Kris Kennaway wrote: > On Fri, Feb 21, 2003 at 08:44:08AM +0900, Jun Kuriyama wrote: > > > > For Kris. :-) > > > > I don't know which option is better. > > > > (1) Add knob like below. > > pros: will not do (bad) effect other PERL_CONFIGURE ports unless > > knob is set. > > cons: requires to add knobs to all ports which has perllocal.pod. > > > > (2) Add reinplace inside of .if defined(PERL_CONFIGURE) and doing this > > implicitly if $PERL_CONFIGURE is defined. > > pros: does not need to touch Makefile of each ports. Only plist fix > > is required. > > cons: may cause some problems (I don't think so, but I don't know > > there is a program which uses perllocal.pod file). It is supposed to be used for de-installation, but currently there is no deinstall target anywhere. Besides, the ports collection handles de-installation mostly fine. So it can be safely removed. Another IMO important cons is the multitude of perllocal.pod-* files in ${PREFIX}/lib, which is undesirable. > Thanks very much! I'll test (2) on bento as soon as I can. I would suggest the complete removal instead: >How-To-Repeat: >Fix: Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.441 diff -u -r1.441 bsd.port.mk --- bsd.port.mk 2 Mar 2003 02:06:56 -0000 1.441 +++ bsd.port.mk 5 Mar 2003 19:36:04 -0000 @@ -2722,7 +2722,7 @@ ${SETENV} ${CONFIGURE_ENV} \ ${PERL5} ./${CONFIGURE_SCRIPT} ${CONFIGURE_ARGS} @cd ${CONFIGURE_WRKSRC} && \ - ${REINPLACE_CMD} -e 's/perllocal.pod/&-${PORTNAME}/' Makefile + ${PERL5} -pi -e 's/ doc_(perl|site)_install$$//' Makefile .endif .if defined(USE_IMAKE) @(cd ${CONFIGURE_WRKSRC}; ${SETENV} ${MAKE_ENV} ${XMKMF}) >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message