Date: Wed, 2 Nov 2011 13:44:14 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Navdeep Parhar <nparhar@gmail.com> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: incorrect parent refcounting in subr_firmware.c? Message-ID: <CAGH67wQ9bsnMGhMs96tC4J26mf=EDJL=MavA0KxnVceH1D6i1A@mail.gmail.com> In-Reply-To: <CAPFoGT9bLzAStkUnSfsBm0F6gmGuCM6kQRHQxa%2Bbsah4mQvQVw@mail.gmail.com> References: <CAPFoGT9bLzAStkUnSfsBm0F6gmGuCM6kQRHQxa%2Bbsah4mQvQVw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 2, 2011 at 12:56 PM, Navdeep Parhar <nparhar@gmail.com> wrote:
> I built a KLD with multiple firmware images, as shown here:
>
> KMOD=foo
> FIRMWS= foo.bin:foo:1.0.0.0
> FIRMWS+=bar.bin:bar:1.0.0.0
> FIRMWS+= ...
> .include <bsd.kmod.mk>
>
> "foo" is the parent firmware and a firmware_get(foo) can autoload the
> KLD. "bar" and the rest are available only if the KLD is loaded (by
> whatever means). This is reasonable and works as expected. But if I
> just get and then put "foo" back, the KLD is not unloaded automatically.
>
> The problem is that a reference is placed on the parent firmware when
> the other firmwares are registered (during module load). I think this
> reference should be placed during firmware_get on the child.
>
> What do people think about the attached patch? It fixes things for me.
It might be a generic problem; here's a similar (not exactly the
same) issue: http://lists.freebsd.org/pipermail/freebsd-hackers/2010-August/032714.html
.
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wQ9bsnMGhMs96tC4J26mf=EDJL=MavA0KxnVceH1D6i1A>