Date: Mon, 07 Jan 2019 19:23:44 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 234704] x11-toolkits/p5-Tk: Do not set CONFIGURE_ARGS twice Message-ID: <bug-234704-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234704 Bug ID: 234704 Summary: x11-toolkits/p5-Tk: Do not set CONFIGURE_ARGS twice Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: pi@FreeBSD.org Reporter: tobik@freebsd.org CC: pi@FreeBSD.org Flags: maintainer-feedback?(pi@FreeBSD.org) Assignee: pi@FreeBSD.org Attachment #200882 maintainer-approval?(pi@FreeBSD.org) Flags: CC: pi@FreeBSD.org Created attachment 200882 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200882&action= =3Dedit x11-toolkits__p5-Tk.diff The port currently sets CONFIGURE_ARGS twice like this CONFIGURE_ARGS=3D X11INC=3D${LOCALBASE}/include X11LIB=3D${LOCALBASE}/lib [...] .if ${PORT_OPTIONS:MXFT} CONFIGURE_ARGS=3D XFT=3D1 USE_XORG+=3D xft .else CONFIGURE_ARGS=3D XFT=3D0 .endif Since the second CONFIGURE_ARGS=3D overwrites the first, X11INC and X11LIB are not in CONFIGURE_ARGS. The port builds fine anyway, so I think the first line should be removed for clarity's sake. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234704-7788>