From owner-cvs-src@FreeBSD.ORG  Sun Jun  8 07:56:44 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E3BB1106564A;
	Sun,  8 Jun 2008 07:56:44 +0000 (UTC)
	(envelope-from tataz@tataz.chchile.org)
Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35])
	by mx1.freebsd.org (Postfix) with ESMTP id 9DA0C8FC13;
	Sun,  8 Jun 2008 07:56:44 +0000 (UTC)
	(envelope-from tataz@tataz.chchile.org)
Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1])
	by smtp5-g19.free.fr (Postfix) with ESMTP id 4718B3F6352;
	Sun,  8 Jun 2008 09:56:43 +0200 (CEST)
Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98])
	by smtp5-g19.free.fr (Postfix) with ESMTP id 367E93F6336;
	Sun,  8 Jun 2008 09:56:43 +0200 (CEST)
Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25])
	by tatooine.tataz.chchile.org (Postfix) with ESMTP id 75F8C9B497;
	Sun,  8 Jun 2008 07:52:56 +0000 (UTC)
Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000)
	id 64ECF4089; Sun,  8 Jun 2008 09:52:56 +0200 (CEST)
Date: Sun, 8 Jun 2008 09:52:56 +0200
From: Jeremie Le Hen <jeremie@le-hen.org>
To: Tim Kientzle <kientzle@FreeBSD.org>
Message-ID: <20080608075256.GA35560@obiwan.tataz.chchile.org>
References: <200805261721.m4QHLCF4070787@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200805261721.m4QHLCF4070787@repoman.freebsd.org>
User-Agent: Mutt/1.5.15 (2007-04-06)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Jun 2008 07:56:45 -0000

Hi Tim,

First of all, thanks for this work.  It greatly contributes to the
cleanness of the overall source tree :-).

On Mon, May 26, 2008 at 05:21:12PM +0000, Tim Kientzle wrote:
> kientzle    2008-05-26 17:21:12 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     gnu/usr.bin/cpio     Makefile 
>   Log:
>   Install GNU cpio as 'gcpio', symlink to 'cpio' unless WITH_BSDCPIO is
>   defined.

There have been much work to glean all build flags over the source tree
into a single place, namely src/share/bsd.own.mk.  See [1].  I think it
would be better to stick to this scheme and not spread those knobs back
in the tree.

[1] http://www.freebsd.org/cgi/cvsweb.cgi/src/share/mk/bsd.own.mk#rev1.44

Thanks.
Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >