From owner-freebsd-ports@FreeBSD.ORG Sat Mar 30 10:04:23 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3EC981BC for ; Sat, 30 Mar 2013 10:04:23 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ie0-x22c.google.com (mail-ie0-x22c.google.com [IPv6:2607:f8b0:4001:c03::22c]) by mx1.freebsd.org (Postfix) with ESMTP id 17539AC3 for ; Sat, 30 Mar 2013 10:04:23 +0000 (UTC) Received: by mail-ie0-f172.google.com with SMTP id c10so1206323ieb.3 for ; Sat, 30 Mar 2013 03:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=rhQqlOYWznHhTFZz5YKQcX5Rj8WUghlfksYmg316I7w=; b=kQGH/NL7EUGp0ecbnHbqqu5qIojgC9n05rsvnbINknwNiBaZvwR1JO45Wf0Swnm+cX /61e6yw0cvPrsvjQRNmblWfWyrEKWE7mXs/z6yht9rug4/8QyDGkiG6VzgZt4+yGSvuV uzjpRxzpUzx/eAoJ0UWk3KYRuJyClcopoEOspIxrKESZ7u3i6XZTNt0jHmiC5h1DkDOv +IEEIkK4OuCrzK88m8/6TNzWMc9R62FyUCzV0q/APQUWO0ncvxsIaMIJuI3MI+Uk+Eo4 J7eSeXAfooGfbi5w/jauajNMmt3eLHdmAdDfZ6zSRPlI6kSVHTTPEkCUDjqknASN7sYU ViUg== X-Received: by 10.50.152.132 with SMTP id uy4mr846711igb.62.1364637862852; Sat, 30 Mar 2013 03:04:22 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.64.58.52 with HTTP; Sat, 30 Mar 2013 03:03:52 -0700 (PDT) In-Reply-To: <20130330034028.0f8cefc8@bsd64.grem.de> References: <20130330034028.0f8cefc8@bsd64.grem.de> From: Chris Rees Date: Sat, 30 Mar 2013 10:03:52 +0000 X-Google-Sender-Auth: ay1NLgggA9OBTLouoYKAhKIceK0 Message-ID: Subject: Re: www/nginx pkg-plist + pkgng (detectable?) To: Michael Gmelin Content-Type: text/plain; charset=ISO-8859-1 Cc: FreeBSD Mailing List X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2013 10:04:23 -0000 On 30 March 2013 02:40, Michael Gmelin wrote: > pkg-plist contains: > > %%WWWDATA%%@exec mkdir -p -m 755 www/nginx-dist > %%WWWDATA%%@exec if [ ! -d %D/www/nginx/ ] ; then ln -fs > %D/www/nginx-dist %D/www/nginx; fi > %%WWWDATA%%www/nginx-dist/EXAMPLE_DIRECTORY-DONT_ADD_OR_TOUCH_ANYTHING > %%WWWDATA%%www/nginx-dist/index.html > %%WWWDATA%%www/nginx-dist/50x.html > %%WWWDATA%%@exec chmod a-w www/nginx-dist > %%WWWDATA%%@unexec if [ -L %D/www/nginx ]; then rm -f %D/www/nginx; fi > %%WWWDATA%%@dirrmtry www/nginx-dist > > cd /usr/ports/www/nginx > make install clean > > # pkg info -R nginx | grep www/nginx-dist > > /usr/local/www/nginx-dist/50x.html: 3c264d74770fd706d59c68d90ca1eb893ac379a666ff136f9acc66ca01daec02 > /usr/local/www/nginx-dist/EXAMPLE_DIRECTORY-DONT_ADD_OR_TOUCH_ANYTHING: 01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b > /usr/local/www/nginx-dist/index.html: 38ffd4972ae513a0c79a8be4573403edcd709f0f572105362b08ff50cf6de521 > /usr/local/www/nginx-dist/: y > mkdir -p -m 755 www/nginx-dist > if [ ! -d /usr/local/www/nginx/ ] ; then ln -fs /usr/local/www/nginx-dist /usr/local/www/nginx; fi > chmod a-w www/nginx-dist > > This means in practice, once you create a binary package (pseudo code): > pkg create nginx > pkg repo . > ... > pkg install nginx > > You'll be left with a www/nginx-dist relative to wherever you've been > in the file. I assume that pkg-plist should use %D/www/nginx instead of > www/nginx in mkdir and chmod. So it's probably a bug in the port > itself. Is this something that pkgng could potentially catch in future? Actually, the current working directory is set with the @cwd command, set to %D by default, so in practice it's not a problem. However... I would agree that you must use %D/ and give absolute paths when running commands in pkg-plist. I would also question the use of mkdir -m 755 then setting mode to 555 with chmod in the next command??? Chris