From owner-freebsd-ports@freebsd.org Tue Jun 26 19:19:41 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D1491012FF8 for ; Tue, 26 Jun 2018 19:19:41 +0000 (UTC) (envelope-from amvandemore@gmail.com) Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 30ABD7FCD9 for ; Tue, 26 Jun 2018 19:19:41 +0000 (UTC) (envelope-from amvandemore@gmail.com) Received: by mail-it0-x229.google.com with SMTP id l16-v6so3176688ita.0 for ; Tue, 26 Jun 2018 12:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZLMj8Uf5HZ7NZhtLdS9jr2cUiO3qVJPR4bQbT+11omU=; b=ZCkKaCXzRWqgtrvm+wxx8diGW89hppMZZy1RKoiNRavDFNLvc4LgEsowGnRAdN29vt nTt24kVxeSnF/8BBhzwfqS+oGrxWCR5mP/KevK0mwljt/MLQ6N+XIc6qtqm46BUQ9+ea HsmdNVHwTH8yIpPieIEx7r+m9iS1EPVzQdLNGhQrsn6qJC7TT8XAmyo7w8iByIVIQz2X pZ+2xWv4hZBp6Fj9/BwRiAOgIvyXlbhsVs++VlyapUec39p5NiLjJ0QW9oRBkB39iI1W LD0nMeE58ModYMZXAbclvIcdtfC1kBUNx9N+XLlGEQ03lWj+TJO8/TULlmtVlBpVTkhs pKEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZLMj8Uf5HZ7NZhtLdS9jr2cUiO3qVJPR4bQbT+11omU=; b=TuHPmO2+YuzNXPCWVCoILkjGI7RMWsFBMhf+KJ3f1J6xcymQJ2vWH+YJ3M89uiegZ0 Ivqay9UnIylOPkjLpmk55KtzmCCsL21rI88psce6wYA+gSX69vRLR9ARQVBp42mVYGoa y9215nTY3R1mwl/JEDA+Uy3zWG2GIx2Ed65SxgJ9gA5GgJyJ7uuAyGCzb1C6XOx9w/XF 5rzX9RGd4zea1CcK60ZWWkL1IONqIK/ODsZvAHNtzJ44D01amnjF+NM/LI2yePKUGesv EvniJa0TveU8u5BYWKPgZfPw5K3Tf4c1nyDgxZCLND3ih60SKx9xw6b7L88Zc5YGR7xf jl3w== X-Gm-Message-State: APt69E2VGDfIdDKnO4dJWkizuTUNzNidTEeJbIZOU2lQrMN2vaPpTbIi HF+44OB4UiOhbyM6cihOVT2Yc0oSvXQPqT6IdZA= X-Google-Smtp-Source: AAOMgpc0wEZlKUrNOqn47MUyfEGumiHSuA6bakhyzWq8+N4YYo794+Gp9AMc7RvHm7LKgqqbDPQgIJAdFbfCcLdk+AM= X-Received: by 2002:a24:9284:: with SMTP id l126-v6mr2647980itd.18.1530040780517; Tue, 26 Jun 2018 12:19:40 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:9c7d:0:0:0:0:0 with HTTP; Tue, 26 Jun 2018 12:19:39 -0700 (PDT) In-Reply-To: <1530036181.4184901.1421203184.0039ADE4@webmail.messagingengine.com> References: <595296BF.3040906@quip.cz> <77549bbc-50b1-7635-2ca4-1ae229098506@quip.cz> <1530036181.4184901.1421203184.0039ADE4@webmail.messagingengine.com> From: Adam Date: Tue, 26 Jun 2018 14:19:39 -0500 Message-ID: Subject: Re: Should a package restart on upgrade itself To: Josh Paetzel Cc: FreeBSD Ports , Miroslav Lachman <000.fbsd@quip.cz> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 19:19:41 -0000 On Tue, Jun 26, 2018 at 1:03 PM, Josh Paetzel wrote: > > Here's the diff for the commit you referenced: > > https://svnweb.freebsd.org/ports/head/emulators/open-vm- > tools/pkg-plist?r1=457023&r2=457485&pathrev=457485 > > Which part are you objecting to? > > I don't really have any objections to changing open-vm-tools. I'll note > that I inherited it in it's current state with regards to defaults and > restarting, an it's probably worth fining out why it does those things > before blatantly changing things. > > It's possible that open-vm-tools is a poor example of what you are talking > about based on it providing services for the OS for running on VMWare > versus running some application service or daemon , but I will have to > think about this before taking a strongly held opinion. > FWIW most daemon equivalent upgrades on Windows force you to chose to restart after an upgrade. There isn't a lot of precedent for automatic, non-confirming restarts in server class software IME. -- Adam