From owner-freebsd-current Sun Mar 2 12:35:59 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94D3037B401 for ; Sun, 2 Mar 2003 12:35:57 -0800 (PST) Received: from scl8owa02.int.exodus.net (scl8out02.exodus.net [66.35.230.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 013D543F3F for ; Sun, 2 Mar 2003 12:35:57 -0800 (PST) (envelope-from Maksim.Yevmenkin@cw.com) Received: from SJDCEX01.int.exodus.net ([165.193.27.80]) by scl8owa02.int.exodus.net with Microsoft SMTPSVC(5.0.2195.5329); Sun, 2 Mar 2003 12:35:56 -0800 X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0 Content-Class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Subject: RE: HEADSUP: Driver mega-commit ahead. Date: Sun, 2 Mar 2003 12:35:56 -0800 Message-ID: <45258A4365C6B24A9832BFE224837D552B1296@sjdcex01.int.exodus.net> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: HEADSUP: Driver mega-commit ahead. thread-index: AcLg+gnqe7ND/VEVRBOb7cAo5Jnw0AAAQPsm From: "Maksim Yevmenkin" To: "Poul-Henning Kamp" , "Marcel Moolenaar" Cc: X-OriginalArrivalTime: 02 Mar 2003 20:35:56.0775 (UTC) FILETIME=[53D61F70:01C2E0FB] Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dear Poul-Henning, i think the following is not correct RCS file: /home/ncvs/src/sys/netgraph/ng_device.c,v retrieving revision 1.2 diff -u -r1.2 ng_device.c --- netgraph/ng_device.c 2 Feb 2003 13:30:00 -0000 1.2 +++ netgraph/ng_device.c 2 Mar 2003 19:48:38 -0000 @@ -66,7 +66,7 @@ /* Netgraph type */ static struct ng_type typestruct =3D { NG_ABI_VERSION, /* version */ - NG_DEVICE_NODE_TYPE, /* name */ + .d_name =3D NG_DEVICE_NODE_TYPE, ng_device_mod_event, /* modevent */ ng_device_cons, /* constructor */ ng_device_rcvmsg, /* receive msg */ @@ -114,19 +114,14 @@ please fix thanks max -----Original Message----- From: Poul-Henning Kamp [mailto:phk@phk.freebsd.dk] Sent: Sun 3/2/2003 12:26 PM To: Marcel Moolenaar Cc: current@FreeBSD.ORG Subject: Re: HEADSUP: Driver mega-commit ahead.=20 In message <20030302202015.GA546@athlon.pn.xcllnt.net>, Marcel Moolenaar = writes : >On Sun, Mar 02, 2003 at 09:14:13PM +0100, Poul-Henning Kamp wrote: >>=20 >> I plan to commit >> http://phk.freebsd.dk/patch/cdevsw.patch >> one of the first days of the week. >>=20 >> Basically, it changes cdevsw initializations to use C99 sparse >> format, and thereby eliminates 859 lines of redundant defaultvalue >> initializations. > >I thought HEAD was in a slush mode. des' sweep and this sweep seems >like the kind of changes we don't want at this time. Has this changed >or did re@ approve it (both cases)? I can't talk for DES sweep, (although I'll say that it seems like a step in the right direction for me). This particular sweep gives os much better cross-branch source portability and therefore I think it is exactly the kind of thing we want before the RELENG_5 branch. --=20 Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe =20 Never attribute to malice what can adequately be explained by = incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message