Date: Sun, 20 Jan 2013 00:12:03 +0100 From: =?ISO-8859-1?Q?Ren=E9_Ladan?= <r.c.ladan@gmail.com> To: Juergen Lock <nox@jelal.kn-bremen.de> Cc: freebsd-ports@freebsd.org Subject: Re: CFT: building multimedia/vlc with clang on 9.1+ Message-ID: <50FB2843.8070705@gmail.com> In-Reply-To: <201301192253.r0JMrhsa080013@triton8.kn-bremen.de> References: <20130119210903.GA76282@triton8.kn-bremen.de> <201301192253.r0JMrhsa080013@triton8.kn-bremen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19-01-2013 23:53, Juergen Lock wrote:
> In article <50FB156A.5010003@gmail.com> you write:
>> On 19-01-2013 22:09, Juergen Lock wrote:
[...]
>>
>>> Index: Makefile
>>> ===================================================================
>>> RCS file: /home/pcvs/ports/multimedia/vlc/Makefile,v
>>> retrieving revision 1.312
>>> diff -u -p -r1.312 Makefile
>>> --- Makefile 12 Jan 2013 20:25:57 -0000 1.312
>>> +++ Makefile 19 Jan 2013 20:45:39 -0000
>>> @@ -679,9 +679,16 @@ IGNORE= base clang version too old, set
>>> CONFIGURE_ARGS+=--enable-altivec # VLC's config script doesn't know to do this
>>> .endif
>>>
>>> +# prefer clang on 9.1+
>>> +.if (${OSVERSION} >= 901000) && exists(${DESTDIR}/usr/bin/clang)
>>
>> Not sure if this is the proper(TM) way to detect clang.
>>> +CC= clang
>>> +CXX= clang++
>>> +CPP= clang-cpp
>>> +.else
>>> .if ${ARCH} == "i386"
>>> USE_GCC?= 4.6+ # sse/3dnow detection on i386 needs newer gcc
>>
>> See above, if on e.g. FreeBSD 12 the /usr/bin/clang file gets removed
>> this makes the port always use GCC 4.6+
>>
> Hmm do you think this would happen? We still had /usr/bin/gcc hardlinked
> to /usr/bin/cc the entire time we used gcc...
>
Not really, but it _could_ happen.
René
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50FB2843.8070705>