Date: Mon, 25 Sep 2017 22:45:08 +0000 (UTC) From: Mathieu Arnold <mat@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r450638 - head/Mk/Scripts Message-ID: <201709252245.v8PMj88O096566@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mat Date: Mon Sep 25 22:45:08 2017 New Revision: 450638 URL: https://svnweb.freebsd.org/changeset/ports/450638 Log: Remove a useless block in the shebang checks. * Once upon a time, we checked all of STAGEDIR/PREFIX's executable files. * We then decided too many false positives were found, so we switched to only checking executable files in bin/sbin/libexec/www, and also symlinks that were in there. * And then, we decided to go back to check all of STAGEDIR/PREFIX's executable files, but forgot to remove the checks for symlinks (which are now useless because we already check all the executable files.) Reported by: lifanov Sponsored by: Absolight Modified: head/Mk/Scripts/qa.sh (contents, props changed) Modified: head/Mk/Scripts/qa.sh ============================================================================== --- head/Mk/Scripts/qa.sh Mon Sep 25 21:51:16 2017 (r450637) +++ head/Mk/Scripts/qa.sh Mon Sep 25 22:45:08 2017 (r450638) @@ -105,26 +105,6 @@ shebang() { -type f -perm +111 2>/dev/null) EOF - # Split stat(1) result into 2 lines and read each line separately to - # retain spaces in filenames. - while read l; do - # No results presents a blank line - [ -z "${l}" ] && continue - read link - - case "${link}" in - /*) f="${STAGEDIR}${link}" ;; - *) f="${l%/*}/${link}" ;; - esac - if [ -f "${f}" ]; then - shebangonefile "${f}" || rc=1 - fi - # Use heredoc to avoid losing rc from find|while subshell - done <<-EOF - $(find ${STAGEDIR}${PREFIX} \ - -type l -exec stat -f "%N${LF}%Y" {} + 2>/dev/null) - EOF - return ${rc} }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709252245.v8PMj88O096566>