From nobody Wed Feb 5 19:43:12 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yp9dD4QKyz5mHLw; Wed, 05 Feb 2025 19:43:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yp9dD26JCz3s8D; Wed, 05 Feb 2025 19:43:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738784592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KcbydVfSpBF1k4Xz/jQs4LHe9uUNSOiYeI7Dc6Nw860=; b=R03MaHKL2HqA+pFeMoGWhlv5nU9E5K9vrS6fZFE5lUKMOAn29+H2RlnMhJMUon2VZEHyq/ CFhri2obvzGqeSt67WWDYWzhZL4S7BHEE+LZzWxZpUeQUsy65Qls7XvmcLVd3le8vUem1V F/JzQ7Gvcg16mB6t/Wkpr/MvHeofz/LeuyQjXZ7JyKWcLLaE75Eshd6b60KCbf57q7Bo0N wJFOhWA+KyZvfsdGOY7ArC/lFZbgGWJMyFONPWcYXSQKdI2SLD/K0AoOoKGcngBzpSSepB gjJ7nq7MQIAHjDgGDrTQQmjK7FPzn0v/lmvPWq5iJzKZ+YWROxFgpaN8DDIq5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738784592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KcbydVfSpBF1k4Xz/jQs4LHe9uUNSOiYeI7Dc6Nw860=; b=veGwuqb+yAw6BGLat4Bc/s6Bje2yu5nDrPHAf/Hjt5fam3yy30RtNoy+6gT7g5uO8K2RuE GlwuM+4p0uN2LXIg43On6i8zRSqZOjpvh/36+h3ldlHnIKqAjzClORxdIV1303cPFoTGhn VAFUJxR8UY8COBvSFkmYy0tfEbAtbpgU5zyRwxjfjvLvmahRkdACsuYTU95yHJcXOEsO5i CCDcJPx/KJAaJdG6zPRQBnNqwjVK8+bJJsnWV2M4D10IyggkyBJHk4DYrYH5heed2vWSDL 6Fiu7YWGRQ3s5nWBitr8lFfBpQQWou4NdXG7YypM+qhHCOzY0aSiHkd78q6Sdw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738784592; a=rsa-sha256; cv=none; b=YK5Gk9FGHg5HOSXg+OCy/3qZ+HBRHqyHpNCrhcc6guzATXWc+VfnOuSFyssczzCsPZaX/T 4BWJg3f/dqlpARFHrHLLVzoNBL+ioFTHpIhrv4tqYIDROrWPA/65R/8jpKhPgSLzutOzoc iOPbalofiG9D5liARy9LC5nsdtfvBhA/xZ0nBKKdxXgg3MuQAl3NElq+8w28yQYgWD1RRS 0AKkFbl0jpq3HDtXccyDMPX8BdRn528GVEynHrcCRlwuz8rFsXOji5V8nk/VAJKk0hWBEw ddcEsDMfPVwfHzBYhpO6jG4ZziiLL4JCAsR0LOluAuz9yLXEr8rEDPgmjGWpBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yp9dD1bpqz15KW; Wed, 05 Feb 2025 19:43:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515JhCsq067894; Wed, 5 Feb 2025 19:43:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515JhCbD067891; Wed, 5 Feb 2025 19:43:12 GMT (envelope-from git) Date: Wed, 5 Feb 2025 19:43:12 GMT Message-Id: <202502051943.515JhCbD067891@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 60682a028156 - stable/13 - TCP RACK, BBR: ensure return value is always ininitialized List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 60682a028156289bbcc69de20198151c44fa5265 Auto-Submitted: auto-generated The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=60682a028156289bbcc69de20198151c44fa5265 commit 60682a028156289bbcc69de20198151c44fa5265 Author: Michael Tuexen AuthorDate: 2024-12-30 15:02:43 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 19:28:20 +0000 TCP RACK, BBR: ensure return value is always ininitialized Do not return an uninitialized value from ctf_do_queued_segments() in case no packets are actually processed (all are skipped). Reviewed by: rrs CID: 1523774 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48217 (cherry picked from commit b5739c8b12226c791bc8e7a4ac6e48965333509a) --- sys/netinet/tcp_stacks/rack_bbr_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack_bbr_common.c b/sys/netinet/tcp_stacks/rack_bbr_common.c index 0a608b92b248..1426043f5326 100644 --- a/sys/netinet/tcp_stacks/rack_bbr_common.c +++ b/sys/netinet/tcp_stacks/rack_bbr_common.c @@ -520,7 +520,7 @@ skipped_pkt: if (no_vn == 0) { CURVNET_RESTORE(); } - return(retval); + return (0); } int