Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2025 19:43:12 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 60682a028156 - stable/13 - TCP RACK, BBR: ensure return value is always ininitialized
Message-ID:  <202502051943.515JhCbD067891@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=60682a028156289bbcc69de20198151c44fa5265

commit 60682a028156289bbcc69de20198151c44fa5265
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2024-12-30 15:02:43 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-05 19:28:20 +0000

    TCP RACK, BBR: ensure return value is always ininitialized
    
    Do not return an uninitialized value from ctf_do_queued_segments()
    in case no packets are actually processed (all are skipped).
    
    Reviewed by:            rrs
    CID:                    1523774
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D48217
    
    (cherry picked from commit b5739c8b12226c791bc8e7a4ac6e48965333509a)
---
 sys/netinet/tcp_stacks/rack_bbr_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netinet/tcp_stacks/rack_bbr_common.c b/sys/netinet/tcp_stacks/rack_bbr_common.c
index 0a608b92b248..1426043f5326 100644
--- a/sys/netinet/tcp_stacks/rack_bbr_common.c
+++ b/sys/netinet/tcp_stacks/rack_bbr_common.c
@@ -520,7 +520,7 @@ skipped_pkt:
 	if (no_vn == 0) {
 		CURVNET_RESTORE();
 	}
-	return(retval);
+	return (0);
 }
 
 int



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502051943.515JhCbD067891>