From owner-freebsd-stable Sat Aug 17 9: 0:35 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 63A9E37B401; Sat, 17 Aug 2002 09:00:31 -0700 (PDT) Received: from pintail.mail.pas.earthlink.net (pintail.mail.pas.earthlink.net [207.217.120.122]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B6D543E65; Sat, 17 Aug 2002 09:00:31 -0700 (PDT) (envelope-from tlambert2@mindspring.com) Received: from pool0218.cvx22-bradley.dialup.earthlink.net ([209.179.198.218] helo=mindspring.com) by pintail.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 17g601-0004Qf-00; Sat, 17 Aug 2002 09:00:25 -0700 Message-ID: <3D5E72E1.F40AF6F7@mindspring.com> Date: Sat, 17 Aug 2002 08:59:29 -0700 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Maxime Henrion Cc: stable@freebsd.org, jlemon@freebsd.org Subject: Re: PATCH2: Better kqueue patches References: <3D5E0E57.3CCF4F70@mindspring.com> <20020817093149.GL14155@elvis.mu.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Maxime Henrion wrote: > If you want to get this committed, it would probably help if you could > generate diffs against -CURRENT. Also, not being a sysV nor a kqueue > expert, your patch looks very nice. Just one small nit: malloc() with > the M_WAITOK flag can't return NULL, so it's useless to test the pointer > against NULL. It's my understanding that it can, under extreme low memory conditions, after a maximum number of tries. However, I merely changed the name of the variable because I was avoiding changing the user visible structure, which would have required tat applications be recompiled in order to use the code; the compare was there before. 8-). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message