From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 19 23:10:09 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87AED1065670 for ; Wed, 19 Jan 2011 23:10:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4431B8FC17 for ; Wed, 19 Jan 2011 23:10:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0JNA9Y9078348 for ; Wed, 19 Jan 2011 23:10:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0JNA94q078342; Wed, 19 Jan 2011 23:10:09 GMT (envelope-from gnats) Resent-Date: Wed, 19 Jan 2011 23:10:09 GMT Resent-Message-Id: <201101192310.p0JNA94q078342@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Benjamin Close Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DC6F106566C for ; Wed, 19 Jan 2011 23:09:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 5E28B8FC18 for ; Wed, 19 Jan 2011 23:09:15 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0JN9FP6002155 for ; Wed, 19 Jan 2011 23:09:15 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p0JN9F9H002154; Wed, 19 Jan 2011 23:09:15 GMT (envelope-from nobody) Message-Id: <201101192309.p0JN9F9H002154@red.freebsd.org> Date: Wed, 19 Jan 2011 23:09:15 GMT From: Benjamin Close To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/154152: BKTR memory leak fix, MFC X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2011 23:10:09 -0000 >Number: 154152 >Category: misc >Synopsis: BKTR memory leak fix, MFC >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 19 23:10:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Benjamin Close >Release: FreeBSD 8 >Organization: >Environment: >Description: Below is details of an MFC that needs to take place. I have handed in my src commit bit and hence are no longer able to perform the MFC. If a kind src developer is able to perform the MFC it would be great. Dear Benjamin Close, As you have requested, I would like to notify you that you have committed a change that may be MFC'ed now, as a testing period specified at the time of that commit is over. For reference purposes following is a copy of your original commit message. Regards, Maxim "MFC Reminder" Sobolev P.S. Please contact Maxim Sobolev if you believe that you received this message due to an error. Author: benjsc Date: Tue May 26 03:56:56 2009 New Revision: 192784 URL: http://svn.freebsd.org/changeset/base/192784 Log: Free the memory correctly in the error case Submitted by: frtzkatz at yahoo.com Approved by: sam MFC after: 1 month Modified: head/sys/dev/bktr/bktr_os.c Modified: head/sys/dev/bktr/bktr_os.c ============================================================================== --- head/sys/dev/bktr/bktr_os.c Tue May 26 03:45:58 2009 (r192783) +++ head/sys/dev/bktr/bktr_os.c Tue May 26 03:56:56 2009 (r192784) @@ -470,7 +470,7 @@ fail: if (bktr->res_irq) bus_release_resource(dev, SYS_RES_IRQ, bktr->irq_rid, bktr->res_irq); if (bktr->res_mem) - bus_release_resource(dev, SYS_RES_IRQ, bktr->mem_rid, bktr->res_mem); + bus_release_resource(dev, SYS_RES_MEM, bktr->mem_rid, bktr->res_mem); return error; } >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: