Date: Tue, 19 Jul 2022 00:23:41 GMT From: Colin Percival <cperciva@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 05350f093663 - main - x86: Remove 1 second DELAY from cpu_reset Message-ID: <202207190023.26J0Nfs9036542@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=05350f09366363d3b5f0349bea6801593ecbddff commit 05350f09366363d3b5f0349bea6801593ecbddff Author: Colin Percival <cperciva@FreeBSD.org> AuthorDate: 2022-07-13 00:43:07 +0000 Commit: Colin Percival <cperciva@FreeBSD.org> CommitDate: 2022-07-19 00:23:25 +0000 x86: Remove 1 second DELAY from cpu_reset On SMP systems, cpu_reset broadcasts a message telling the APs to stop themselves, and then the BSP waits 1 second before actually resetting itself; this behaviour dates back to 1998-05-17. I assume that this delay was added in order to allow the APs to stop themselves before the BSP resets; but we wait until the APs have all acknowledged entering the "stopped" state, so it no longer seems to serve any purpose. Reviewed by: jhb, kib Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D35797 --- sys/x86/x86/cpu_machdep.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/x86/x86/cpu_machdep.c b/sys/x86/x86/cpu_machdep.c index 040438043c73..b96e50d785fa 100644 --- a/sys/x86/x86/cpu_machdep.c +++ b/sys/x86/x86/cpu_machdep.c @@ -508,8 +508,6 @@ cpu_reset(void) /* NOTREACHED */ } } - - DELAY(1000000); } #endif cpu_reset_real();
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202207190023.26J0Nfs9036542>