From owner-svn-src-head@freebsd.org Wed Sep 23 18:18:23 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60798A07AB3; Wed, 23 Sep 2015 18:18:23 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x229.google.com (mail-pa0-x229.google.com [IPv6:2607:f8b0:400e:c03::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 30F2F1C60; Wed, 23 Sep 2015 18:18:23 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacfv12 with SMTP id fv12so47851591pac.2; Wed, 23 Sep 2015 11:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9ZsMVmzMl5buqFp5NKLsgmysMWWpg0J/qHZUIlLOqZk=; b=JkHMgkNTYqkG52kZArEzCjLKOprrkr2B3bmaiVSPlb5MMvk/RqI2DHO8VKDJMxDAJ3 9uVDUGvJhr82JBWiCE+paj28jWybiqU1yUaXnKe1iKPFQcl5//G7HWbmzDvMkVabSmmY 9EdcWXPgKgLfpxeGaoRLopm0T1hdKqWDWGug/uGD/6dmXdhyfjL/ddrRt6hslM3S+PHx r1bXVHyBxTQUZlwBrj6fD640pZQWmeC29eSV/jdmPbUw7jBO+XOOl0enPtmt4bL5YTS0 2dgaxB4CYOdlsNONr+HU4QAUKIJtmdZqrPcEJyTJ/ECJG95zr5i8iYjVO5BX6T7WjMie 1Hxw== X-Received: by 10.68.204.37 with SMTP id kv5mr34370298pbc.64.1443032302652; Wed, 23 Sep 2015 11:18:22 -0700 (PDT) Received: from ?IPv6:2601:601:800:126d:5925:dd87:4f43:d34d? ([2601:601:800:126d:5925:dd87:4f43:d34d]) by smtp.gmail.com with ESMTPSA id rz9sm9172121pbb.61.2015.09.23.11.18.21 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Sep 2015 11:18:21 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r286995 - head/share/mk From: Garrett Cooper X-Mailer: iPhone Mail (12H321) In-Reply-To: <5602DB13.2000202@FreeBSD.org> Date: Wed, 23 Sep 2015 11:18:21 -0700 Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <201508211515.t7LFFM0U028322@repo.freebsd.org> <56023395.2080904@FreeBSD.org> <5602DB13.2000202@FreeBSD.org> To: Bryan Drewery X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 18:18:23 -0000 > On Sep 23, 2015, at 10:02, Bryan Drewery wrote: >=20 >> On 9/23/2015 9:44 AM, Warner Losh wrote: >>=20 >>=20 >> On Tue, Sep 22, 2015 at 10:07 PM, Bryan Drewery > > wrote: >>=20 >>> On 8/21/15 8:15 AM, Warner Losh wrote: >>> Author: imp >>> Date: Fri Aug 21 15:15:22 2015 >>> New Revision: 286995 >>> URL: https://svnweb.freebsd.org/changeset/base/286995 >>>=20 >>> Log: >>> Document bsd.progs.mk , including its >> status as being strongly >>> discouraged and that it will be going away as soon as is >> practicable. >>>=20 >>> Modified: >>> head/share/mk/bsd.README >>=20 >> I find this functionality irreplaceable for simplicity. The alternativ= e >> is more Makefiles for simple extra progs. Granted it has meta mode >> dirdeps issues but I think that is acceptable as there are other ways t= o >> address that. >>=20 >> Where is this deprecation coming from? Is it just due to bapt's >> in-progress (but not working) patch at https://reviews.freebsd.org/D34= 44 >> to remove bsd.progs.mk in place of PROGS in >> bsd.prog.mk ? >>=20 >> I would like to document PROGS properly. I had no idea how it worked >> until reading over it tonight. If the plan wasn't to remove PROGS itse= lf >> I will do so. >>=20 >>=20 >> It doesn't work and has lots of issues. Those issues haven't been fixed. >> It didn't look like they would be fixed any time soon. It seemed there >> was a consensus to deprecate it because of those issues. >> bapt was part of that group, and his problems with packaging that >> bsd.progs.mk creates played into this decision. >>=20 >> If the issues are fixed, then we can change our recommendations based >> on the changed circumstance. >>=20 >> Warner >=20 > Yes I think I've addressed the issues. I'm still testing and will have > it committed soon. It is still fragile, but most of share/mk is. I know you've been playing with meta mode a lot. Have you tried building wit= h non-meta mode, with MK_TESTS=3Dyes, then run he following steps as root af= ter a successful installworld? NOTE: wipe out /usr/tests before running installworld to ensure the files th= at are present there aren't from previous runs cd /usr/tests kyua test Please add me to the CR. Thanks, -NGie=