From owner-dev-commits-src-main@freebsd.org Thu Jan 14 06:33:19 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6C02C4D71AC; Thu, 14 Jan 2021 06:33:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DGZJH2VXdz4rdH; Thu, 14 Jan 2021 06:33:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4877225528; Thu, 14 Jan 2021 06:33:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 10E6XJwG031697; Thu, 14 Jan 2021 06:33:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 10E6XJGg031696; Thu, 14 Jan 2021 06:33:19 GMT (envelope-from git) Date: Thu, 14 Jan 2021 06:33:19 GMT Message-Id: <202101140633.10E6XJGg031696@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 03774659d1f2 - main - tools: git hooks: drop "submitted by" from commit template MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 03774659d1f24d47ce00e165048a253263028cff Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2021 06:33:19 -0000 The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=03774659d1f24d47ce00e165048a253263028cff commit 03774659d1f24d47ce00e165048a253263028cff Author: Kyle Evans AuthorDate: 2021-01-14 06:33:07 +0000 Commit: Kyle Evans CommitDate: 2021-01-14 06:33:07 +0000 tools: git hooks: drop "submitted by" from commit template With the switch to git, we should strive to properly attribute every commit appropriately with the metadata that's provided to do so. In this case, the submitter should be recorded via the author metadata. Committing an arbitrary patch, one can set it as such: git commit --author="John Smith " Reviewed-by: emaste Differential-Revision: https://reviews.freebsd.org/D28069 --- tools/tools/git/hooks/prepare-commit-msg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/tools/git/hooks/prepare-commit-msg b/tools/tools/git/hooks/prepare-commit-msg index 51b92a10724d..0ebec48fd9a5 100755 --- a/tools/tools/git/hooks/prepare-commit-msg +++ b/tools/tools/git/hooks/prepare-commit-msg @@ -43,7 +43,6 @@ $(awk '1;/^#$/{exit}' $1) # Uncomment and complete these metadata fields, as appropriate: # # PR: -# Submitted by: # Reported by: # Reviewed by: # Approved by: @@ -57,7 +56,8 @@ $(awk '1;/^#$/{exit}' $1) # Differential Revision: # # "Pull Request" and "Differential Revision" require the *full* GitHub or -# Phabricator URL. +# Phabricator URL. The commit author should be set appropriately, using +# \`git commit --author\` if someone besides the committer sent in the change. $(awk '/^#$/,EOF' "$1") EOF