From owner-freebsd-gnome@FreeBSD.ORG Sat Aug 9 14:52:24 2008 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34B031065677 for ; Sat, 9 Aug 2008 14:52:24 +0000 (UTC) (envelope-from jsatkinson@embarqmail.com) Received: from mailrelay.embarq.synacor.com (mailrelay.embarq.synacor.com [208.47.184.3]) by mx1.freebsd.org (Postfix) with ESMTP id D04398FC16 for ; Sat, 9 Aug 2008 14:52:23 +0000 (UTC) (envelope-from jsatkinson@embarqmail.com) DKIM-Signature: v=1; a=rsa-sha1; d=embarqmail.com; s=s012408; c=relaxed/simple; q=dns/txt; i=@embarqmail.com; t=1218292342; h=From:Subject:Date:To:MIME-Version:Content-Type; bh=xhdCzKkiT/HhtMyK0K1Vxm/QT+A=; b=fY/5XVJkbOYlS4rTzICvC0LvfmmbuL6ClgoCU1khrxmgTJHgM3di3sPO4yxojAXd aO0oFvFW6YSf+BwS7CBtC80CP4mrhF8vPA/VnsgKzQeIN3Ri1RlYwhG0j5b867ND; X_CMAE_Category: 0,0 Undefined,Undefined X-CNFS-Analysis: v=1.0 c=1 a=-eUr9JJtfEtEw3K2Sz0A:9 a=ywr-sApM5cMsFXQeWI69OOqIQlQA:4 a=ok68_o4NJqgA:10 a=VFPMDatD0Xk7Tp6M5aEA:9 a=JN9zf-d6bRlETAD5VfQOCJtCot0A:4 a=rPt6xJ-oxjAA:10 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine Authentication-Results: smtp06.embarq.synacor.com smtp.user=jsatkinson@embarqmail.com; auth=pass (LOGIN) Received: from [76.7.160.127] ([76.7.160.127:60204] helo=[192.168.2.100]) by mailrelay.embarq.synacor.com (envelope-from ) (ecelerity 2.2.1.28 r(22594)) with ESMTPA id 6B/C9-31283-57AAD984; Sat, 09 Aug 2008 10:32:22 -0400 Message-ID: <489DAA80.7020704@embarqmail.com> Date: Sat, 09 Aug 2008 10:32:32 -0400 From: "Joseph S. Atkinson" User-Agent: Thunderbird 2.0.0.16 (X11/20080807) MIME-Version: 1.0 To: Pav Lucistnik Content-Type: multipart/mixed; boundary="------------050806070003020300000203" Cc: Seth Kingsley , FreeBSD GNOME Subject: ports-mgmt/bpm X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Aug 2008 14:52:24 -0000 This is a multi-part message in MIME format. --------------050806070003020300000203 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Pav, You asked me to submit a fix for ports-mgmt/bpm since I discovered it was recently broken on 8. Here it is. I can't figure out what it needs to include bsd.sys.mk for, and it seems build/install/run fine without it. Maybe it's something historical and now provided by ports' Mk universe. Anyway, the patch just comments out that entire .if block and skips the include. I cc'ed the author/maintainer since it should have his notice and/or input before going in. Also, he may be willing to shed some insight on why bsd.sys.mk was included (and only for FreeBSD) in the first place. In looking at files/patch-src::refresh.c, there is a big block comparing the __FreeBSD_version number. This requires periodic updates to as FreeBSD progresses through major version numbers. If we devise a way to pass ${INDEXFILE} (see Mk/bsd.port.mk) directly to the build, the port should keep working until something truly fundamental breaks. Additionally, I cc'ed gnome@ because this port is included in the x11/gnome2-power-tools meta and figured the above might be of interest to them. --------------050806070003020300000203 Content-Type: text/plain; name="patch-mk_sk.global.mk" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch-mk_sk.global.mk" --- mk/sk.global.mk.orig 2008-08-09 08:27:47.000000000 -0400 +++ mk/sk.global.mk 2008-08-09 08:29:12.000000000 -0400 @@ -51,10 +51,6 @@ .PATH: ${.CURDIR}/${BASE_DIR}/mk/src PICFLAGS = -fpic -.if ${OSTYPE} == "FreeBSD" -.include -.endif - CXX?= c++ AR?= ar --------------050806070003020300000203--