Date: Wed, 29 Jan 2003 13:54:57 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Benno Rice <benno@FreeBSD.org> Cc: current@FreeBSD.org, Juli Mallett <jmallett@FreeBSD.org>, Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: Patch to teach config(8) about "platforms". Message-ID: <XFMail.20030129135457.jhb@FreeBSD.org> In-Reply-To: <1043828377.648.67.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29-Jan-2003 Benno Rice wrote: > On Wed, 2003-01-29 at 18:46, Marcel Moolenaar wrote: >> On Wed, Jan 29, 2003 at 05:32:51PM +1100, Benno Rice wrote: >> > > >> > > Agreed. There's an advantage there, but see also my reply to >> > > Juli about the use of "machine" to mean MACHINE_ARCH and the >> > > use of "platform" to mean MACHINE. This I don't find appealing. >> > >> > I can see your point here, but if needed I'd rather see them renamed to >> > MACHINE (which maps to the current MACHINE_ARCH) and PLATFORM as MACHINE >> > and MACHINE_ARCH are confusingly similar. >> >> I'm not sure I understand you. I don't mind the capitalization, >> just that we have MACHINE_ARCH and MACHINE defined on the hand >> and "machine" and "platform" on the other. If you would ask a >> person how they should be related, I can imagine that the >> logical should would be to relate "machine" to MACHINE and >> "platform" to MACHINE_ARCH. Which is opposite to what Juli >> proposed. That's the unappealing part. Not a biggy, but >> something that's better avoided now than fixed later. > > In that case I'm mostly in agreement. Avoiding confusion is a Good > Thing(tm). Just be consistent please. Ignore the implementation and choose one of these two paths: 1) Use MACHINE and MACHINE_ARCH with MACHINE_ARCH being the architecture and MACHINE being the platform and use the 'machine' keyword for MACHINE with MACHINE_ARCH either explicit (in which case 'machine' defaults to 'arch' just like MACHINE defaults to MACHINE_ARCH) or implicit from the config file location. 2) Use PLATFORM and MACHINE with matching config keywords and if platform is not specified it defaults to MACHINE. I don't really care which, but please just pick one and be fully consistent. If you go with 1), I suggest an alternative header file layout where you have an /usr/include/arch and the machine/ headers (which are platform-specific) include the arch/ headers for common things. I think both ways can work, but please do not change the meaning of one set w/o changing the other. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030129135457.jhb>