From owner-cvs-src@FreeBSD.ORG Sat Apr 3 12:08:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9024616A4CE; Sat, 3 Apr 2004 12:08:03 -0800 (PST) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 404C943D45; Sat, 3 Apr 2004 12:08:03 -0800 (PST) (envelope-from danfe@regency.nsu.ru) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.30) id 1B9rRy-0007j6-8O; Sun, 04 Apr 2004 03:09:06 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i33K8jxm019374; Sun, 4 Apr 2004 03:08:45 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.10/8.12.10/Submit) id i33K8jZQ019357; Sun, 4 Apr 2004 03:08:45 +0700 (NOVST) (envelope-from danfe) Date: Sun, 4 Apr 2004 03:08:44 +0700 From: Alexey Dokuchaev To: Ruslan Ermilov Message-ID: <20040403200844.GA18516@regency.nsu.ru> References: <20040331211028.37B5016A4E2@hub.freebsd.org> <20040331134609.N90425@root.org> <20040401064241.GA18644@ip.net.ua> <20040401105857.GA72284@regency.nsu.ru> <20040401135011.GB378@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040401135011.GB378@ip.net.ua> User-Agent: Mutt/1.4.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Nate Lawson Subject: Re: cvs commit: src/sys/pci if_ste.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2004 20:08:03 -0000 On Thu, Apr 01, 2004 at 04:50:11PM +0300, Ruslan Ermilov wrote: > On Thu, Apr 01, 2004 at 05:58:57PM +0700, Alexey Dokuchaev wrote: > > On Thu, Apr 01, 2004 at 09:42:41AM +0300, Ruslan Ermilov wrote: > > > On Wed, Mar 31, 2004 at 01:47:16PM -0800, Nate Lawson wrote: > [...] > > > > This pollutes the toplevel hw sysctl space. Please move it to > > > > hw.ste.rxsyncs or better, debug.*. > > > > > > > Seems I followed the bad practice from dc(4) and fxp(4). I will > > > move it to hw.ste, thanks. > > > > Care to fix this "bad practice" in dc(4) and fxp(4) as well? :) Or > > should we wait for their maintainers, or possibly filling the PR ? > > > Better submit a patch, it should be pretty trivial. ;) OK, I'll do it in a couple of days, hopefully for both dc(4) and fxp(4). ./danfe