From owner-svn-src-all@FreeBSD.ORG  Tue Feb 10 14:04:37 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 76B37106567A;
	Tue, 10 Feb 2009 14:04:37 +0000 (UTC)
	(envelope-from p.pisati@oltrelinux.com)
Received: from joe.mail.tiscali.it (joe.mail.tiscali.it [213.205.33.54])
	by mx1.freebsd.org (Postfix) with ESMTP id F22D88FC1F;
	Tue, 10 Feb 2009 14:04:36 +0000 (UTC)
	(envelope-from p.pisati@oltrelinux.com)
Received: from newluxor.wired.org (94.36.96.185) by joe.mail.tiscali.it
	(8.0.022) id 496E020E017F6E68; Tue, 10 Feb 2009 14:52:54 +0100
Message-ID: <499186B0.6030109@oltrelinux.com>
Date: Tue, 10 Feb 2009 14:52:48 +0100
From: Paolo Pisati <p.pisati@oltrelinux.com>
User-Agent: Thunderbird 2.0.0.18 (X11/20081214)
MIME-Version: 1.0
To: Randall Stewart <rrs@lakerest.net>
References: <200902091142.n19BgNnb059032@svn.freebsd.org>
	<20090209124141.GA2071@dchagin.static.corbina.ru>
	<32F47187-B1D5-4EE3-A1ED-0FE4CD5998AC@lakerest.net>
In-Reply-To: <32F47187-B1D5-4EE3-A1ED-0FE4CD5998AC@lakerest.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Chagin Dmitry <dchagin@freebsd.org>
Subject: Re: svn commit: r188388 - head/sys/netinet
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2009 14:04:38 -0000

Randall Stewart wrote:
> Hmm..
>
> My guess is it has to do with the NAT stuff that
> Paolo is working on. Basically the ipfw/nat is becoming
> SCTP aware and I believe we made the sctp_crc32c routines
> public so that he could access them.
>
> Paolo: maybe you need to include <opt_sctp.h> and then do
> some sort of
>
> #ifdef SCTP
>
> #endif
>
> Around the csum calls int crc32??
the problem with opt_scpt is that it's not available during module 
compilation.

my other solution:

-we define 2 functions ptrs: update_crc32_ptr and 
sctp_finalize_crc32_ptr, and initialize them with NULL
-during the SCPT initialization path, we set those 2 ptrs to point to 
the actual SCTP functions
-in alias_sctp.c, we check the value:
 -in case it's NULL, SCTP wasn't compiled in and thus we return 0
 -else we call the pointed functions

the only remaining open problem is where to put these 2 ptrs: it has to 
be a place that is always compiled in, but on the other hand
we should limit pollution.