From owner-freebsd-firewire@FreeBSD.ORG Thu Feb 12 20:07:30 2009 Return-Path: Delivered-To: freebsd-firewire@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3800106566B; Thu, 12 Feb 2009 20:07:30 +0000 (UTC) (envelope-from ganbold@micom.mng.net) Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88]) by mx1.freebsd.org (Postfix) with ESMTP id 964938FC0C; Thu, 12 Feb 2009 20:07:30 +0000 (UTC) (envelope-from ganbold@micom.mng.net) Received: from [202.179.21.161] (helo=beastie.micom.mng.net) by publicd.ub.mng.net with esmtpa (Exim 4.69 (FreeBSD)) (envelope-from ) id 1LXcXg-000Jd8-Qu; Thu, 12 Feb 2009 22:27:53 +0800 Message-ID: <4994320B.4060900@micom.mng.net> Date: Thu, 12 Feb 2009 22:28:27 +0800 From: Ganbold User-Agent: Thunderbird 2.0.0.19 (X11/20090127) MIME-Version: 1.0 To: Sean Bruno References: <1234414082.30696.185.camel@localhost.localdomain> In-Reply-To: <1234414082.30696.185.camel@localhost.localdomain> X-Enigmail-Version: 0.95.7 OpenPGP: id=78F6425E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: scottl@freebsd.org, freebsd-firewire@FreeBSD.org Subject: Re: Final patch for -current X-BeenThere: freebsd-firewire@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Firewire support in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2009 20:07:31 -0000 Sean, How about following redundant loop near the end of fwohci.c? --- sys/dev/firewire/fwohci.c 2008-11-22 14:39:45.000000000 +0800 +++ /var/current/mysrc/sys/dev/firewire/fwohci.c 2008-11-25 11:36:09.000000000 +0800 @@ -2973,7 +2973,7 @@ db_tr = STAILQ_NEXT(db_tr, link); resCount = FWOHCI_DMA_READ(db_tr->db[0].db.desc.res) & OHCI_COUNT_MASK; - } while (resCount == 0) + } printf(" done\n"); dbch->top = db_tr; dbch->buf_offset = dbch->xferq.psize - resCount; thanks, Ganbold Sean Bruno wrote: > Allrighty, this patch wraps up my -current work and should establish a > nice baseline for my debugging of problems. > > Introduce struct sbp_dev.bustgtlun to replace the overloaded > show_sdev_info() in most places. This is an optimization of the debug > case fortunately. Stash the BB:TT:LL string here for later > device_printf() goodness. > > More debugging cleanup printf()-->device_printf() > > Explicity set the callout sdev->login_callout to acquire the sbp mtx. > > Rename sbp_alloc_target() variable i to new_target_id. Clarity is good, > even in temporary variables. > > Cleanup and document the sbp_login() function. This function is a bit > hairy, so document what it's supposed to do. > > Add some locking in sbp_probe_target() > > Assert the sbp mtx in sbp_write_cmd_locked() > > Avoid LoR in sbp_mgm_orb() and assert sbp mtx locked. > > Acquire sbp mtx before sbp_mgm_orb() is invoked. > > Sean > > ------------------------------------------------------------------------ > > _______________________________________________ > freebsd-firewire@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-firewire > To unsubscribe, send any mail to "freebsd-firewire-unsubscribe@freebsd.org" -- I have a friend whose a billionaire. He invented Cliff's notes. When I asked him how he got such a great idea he said, "Well first I... I just... to make a long story short..." -- Steven Wright