From owner-freebsd-current@freebsd.org Fri Feb 5 09:02:18 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C26DA761A2 for ; Fri, 5 Feb 2016 09:02:18 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1165A786; Fri, 5 Feb 2016 09:02:18 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm0-x234.google.com with SMTP id g62so17477297wme.0; Fri, 05 Feb 2016 01:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-type:content-transfer-encoding; bh=5DzqyKFH2DSrphF7nGW5fNTDdx6AolZHs4IsnFiosAU=; b=ADhvnp55Ta3XYGCz4DYub5tV3qXacoEl9HfKI2Tunw5biaQcN+DYId4D8TbiCRq4Y3 HwBVA6YMSfbQl8l3Gabmq5kVd57w99hfZtQ8jDs33CADaqnEaKJTKTMJXDkrr5dvPNAY bxUmCva5BCuGT7mdqESxnaZgezluIkhPwgHBlEk7vSWqeYAUBGSJLLL13I/Cyntl8DUf w1GpWjEUe160SHUmH/cQNmYgnocsT01uX9M+f/nbAaJ9wlKr9wla+aeZaYByi6S1UeI9 2AdKfn94Nl1Hn4R+h1puTX6Y71lFeGk8SIA7pFOkLprRXeg644yicHIWrakVMQvmYgjP lwDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-type :content-transfer-encoding; bh=5DzqyKFH2DSrphF7nGW5fNTDdx6AolZHs4IsnFiosAU=; b=gxDMv4Gqrl9ejLGAzPLuANrkSXMGDlhMZp0Og3xP4y+wnjDBW6qwRttTahJl2Nt1sf Nb5NaZqccd2pIsk0/9gAP1cWdeySwtlLvAXIR2mjVxLPC5eAmwT3sVwhgqPZfF7UIf/W yA6HBulrlFT9SCrcOorcBnZ5Tzocq2AgKDCgfll81QGL4vJ+Zk2nHrsjj1wHcRC65dZg sxknLLqd3je4DjAYbPHBOdsqdCEUWoHI4Mlp2xluvePkuQ1bTuzXrSsEhQh/Iyo4m+7h 4QqjTgcSMeEIafrRv9YU7X9DhxudJirWCYbTNxgqmtrZa8rQKI0M+VpnZ/4HAX/x4dZu aLmg== X-Gm-Message-State: AG10YOSDgVUX5dRjGn8BCNtCvYHnop8dq/QYAXo2demIU6vSGfPicVpFfJsRkeKCPYGcJA== X-Received: by 10.28.224.84 with SMTP id x81mr32632879wmg.62.1454662936005; Fri, 05 Feb 2016 01:02:16 -0800 (PST) Received: from ernst.home (p578E04A2.dip0.t-ipconnect.de. [87.142.4.162]) by smtp.gmail.com with ESMTPSA id i2sm14861790wjx.42.2016.02.05.01.02.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Feb 2016 01:02:15 -0800 (PST) Date: Fri, 5 Feb 2016 10:02:12 +0100 From: Gary Jennejohn To: Mark Johnston Cc: Eric van Gyzen , FreeBSD Current Subject: Re: Kernel memory leak with x11/nvidia-driver Message-ID: <20160205100212.3ff372f4@ernst.home> In-Reply-To: <20160205020543.GA1661@wkstn-mjohnston.west.isilon.com> References: <56B230CB.3050600@FreeBSD.org> <56B3E0B4.4090603@FreeBSD.org> <20160205020543.GA1661@wkstn-mjohnston.west.isilon.com> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 09:02:18 -0000 On Thu, 4 Feb 2016 18:05:43 -0800 Mark Johnston wrote: > On Thu, Feb 04, 2016 at 05:37:24PM -0600, Eric van Gyzen wrote: > > On 02/ 3/16 10:54 AM, Eric van Gyzen wrote: > > > I just set up a new desktop running head with x11/nvidia-driver. I've > > > discovered a memory leak where pages disappear from the queues, never to > > > return. Specifically, the total of > > > v_active_count > > > v_inactive_count > > > v_wire_count > > > v_cache_count > > > v_free_count > > > drops, eventually becoming /much/ less than v_page_count. After leaving > > > xscreensaver running overnight, cycling the saver every 10 minutes, the > > > system was unusable, because it only had a few MB of memory. (It has 8 > > > GB physical.) > > > > In case anyone is curious, /usr/local/bin/xscreensaver-hacks/glmatrix > > triggers a fairly fast leak--around 600 pages per second. > > I'm able to repro this on my workstation. With DTrace I can see that > glmatrix is allocating pages for an SG object at roughly the rate > they're being leaked. I took a look at r292373 (based on the history of > sg_pager.c) and noticed a vm_page_free() call was lost when > sg_pager_getpages() was simplified. > > The patch below seems to do the trick for me. Could you give it a try > and confirm that it fixes the problem? I run current+nvidia-driver on > multiple workstations but hadn't observed a leak until now, so maybe > there's something additional going on in your case. Then again, I just > use i3lock. :) > > diff --git a/sys/vm/sg_pager.c b/sys/vm/sg_pager.c > index 84bfa49..2cccb7ea 100644 > --- a/sys/vm/sg_pager.c > +++ b/sys/vm/sg_pager.c > @@ -189,6 +189,9 @@ sg_pager_getpages(vm_object_t object, vm_page_t *m, int count, int *rbehind, > VM_OBJECT_WLOCK(object); > TAILQ_INSERT_TAIL(&object->un_pager.sgp.sgp_pglist, page, plinks.q); > vm_page_replace_checked(page, object, offset, m[0]); > + vm_page_lock(m[0]); > + vm_page_free(m[0]); > + vm_page_unlock(m[0]); > m[0] = page; > page->valid = VM_PAGE_BITS_ALL; > I started looking at this yesterday after seeing the OP and verified that I was also losing pages. With this patch no more pages are lost. Good work! -- Gary Jennejohn