From owner-freebsd-current@FreeBSD.ORG Sun Oct 27 15:40:49 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2C34EC9B for ; Sun, 27 Oct 2013 15:40:49 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm18-vm0.bullet.mail.bf1.yahoo.com (nm18-vm0.bullet.mail.bf1.yahoo.com [98.139.213.138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B0B852D9B for ; Sun, 27 Oct 2013 15:40:48 +0000 (UTC) Received: from [98.139.212.147] by nm18.bullet.mail.bf1.yahoo.com with NNFMP; 27 Oct 2013 15:38:24 -0000 Received: from [68.142.230.64] by tm4.bullet.mail.bf1.yahoo.com with NNFMP; 27 Oct 2013 15:38:24 -0000 Received: from [127.0.0.1] by smtp221.mail.bf1.yahoo.com with NNFMP; 27 Oct 2013 15:38:24 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1382888304; bh=7BhF0cpj4Z0wboxD/dH7XcxmkZZKqpZOwcJ3h4yoVn8=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=1odQMwWzFnMSNTdM9WB6Zd/38g/4ZASx/jdrb0zsAN566oWXrCKDc5Gl9D/HVh/WDl8hcFSRCoE3WU/nvrBQDW/lUN1icCwjLW/Awu9qedZEY99Q294qT0khkcyIcU6wJtG/iMBOKVDlk+zQnsSCS4A6elx+G5i/v8X9f2PaETI= X-Yahoo-Newman-Id: 231728.86100.bm@smtp221.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: fwE4_KIVM1njp4EV8rMqz.A22HPXcnyHPeDO6N2EqYZtyAM .un83z6SOrT4riraDuFkEsObuC7R6pzTqWkrLX3ZHDNWt4ReC8c.f6TAOT9v Vfag9bwlxOC9V3U4dTkNimgzjum0HgLPkACn1bGbaG8OVCbpdgqJhGzAlzNn stXD3xZRrX_QLUzWMTDTv8DLAcRQ_FY4h1KpQ9YlibWzuOc0k38SajJFDmnL cnwzocpCTboF7iUIKX_pwO8RIEC9jocR083AgvQHkT_tF2tQxJgNyc7.r2oq yTctB6.6k9WfMuKcXJuf0CV.1m2Q6jKHIWqFE2I8A4ammYn0AIxFGDGZlTL9 LJryy3SATjiy7YvWmip2hN7xXEVUAcyK8t4pLPWbWdCFilh8ICMCTBj48h.F VlYttML8yGIW5SOoGpWCtN8lA9Qge.YT1QsrfpdNWbPaowZfQ1P04_RUzINv oBAD803XuDdDibdlLdR6yQG0BI6C2yEBP6G_fYvgxHYTNyiSuF0RKZmLDybs 3ic7NGaii_ljRn9x1cMDWnwF8Fh.UIKOPkpf2eIcVCqeIoZCX1pFX9Q-- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [10.3.13.24] (sean_bruno@64.197.173.10 with ) by smtp221.mail.bf1.yahoo.com with SMTP; 27 Oct 2013 15:38:24 +0000 UTC Subject: Re: [PATCH] contrib/groff Queisce -Wdangling else From: Sean Bruno To: Eitan Adler In-Reply-To: References: <1382799852.32760.2.camel@localhost> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-ZNbtej2iHF4DLutZa7Mt" Date: Sun, 27 Oct 2013 11:38:21 -0400 Message-ID: <1382888301.4717.4.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: "freebsd-current@freebsd.org" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 15:40:49 -0000 --=-ZNbtej2iHF4DLutZa7Mt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Sat, 2013-10-26 at 20:22 -0400, Eitan Adler wrote: > On Sat, Oct 26, 2013 at 11:04 AM, Sean Bruno wrote= : > > This adds proper braces to clear Clang warnings about dangling else > > statements in groff. There is no(intended) functional change. >=20 >=20 > For contributed code why not just disable warnings? Fixing code is > good but doing so in our repository instead of upstream doesn't help > as much. >=20 >=20 I believe very strongly that the people who construct compilers know C/C ++ far better than I do, so warnings are their note to me that I'm doing it wrong. Disabling warnings is global for a section of the tree (e.g. groff/roff). I can't (easily) isolate the warnings individually, so modifications to the code after I disable the warnings will get excluded as well, effectively opening the project to crappy code that breaks things (if the warnings are causing bugs). For this specific code (groff), it switched to gpl v3 in 2009, so we won't be doing any more code drops into our tree: Revision 1.5 - (view) (download) (annotate) - [select for diffs]=20 Sun Jan 4 14:50:51 2009 UTC (4 years, 9 months ago) by wl=20 Branch: MAIN=20 Changes since 1.4: +3 -3 lines=20 Diff to previous 1.4=20 * */*: Update GPL2 to GPL3. Therefore, if someone isn't going to rewrite the implementations, its up to us to maintain the code we have. sean "Warnings are meaningful." FreeBSD Clusteradm/Developer --=-ZNbtej2iHF4DLutZa7Mt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSbTNkAAoJEBkJRdwI6BaHyOUH/126jddDrGoa1pZBLYDzqiv4 kUy6zoycgrrFL7n+/moBK7IqAu8vA4VIRJfn5G+ThN6Z2z5xPBM5YHx7hPK0XXpG VyzWycmYRlUBDBJF7NNz+VfB+Kjwm29n3JoEgp2sfHIvxufIsOxrVAKwbRrQ0qbK kYXEcejKPOhgP8v1cwYFQjZW58b6yDSDkreoESE1DuVyUd8K7b4bey9rMMa9Jclo 9LNzthocbDhd2k8lazzl6UZBbWRo5Egv5qwN9K7heOjXfymAolzCy2NU3Mo28OxO owHumYubTuKaJYdyb03fifWKVxrcqk+SCBFhTsyb6lo41nKy5XjRzzM61YYvvn4= =2//t -----END PGP SIGNATURE----- --=-ZNbtej2iHF4DLutZa7Mt--