From owner-freebsd-bugs@FreeBSD.ORG  Thu Jun 19 03:50:04 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 575991065748
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 19 Jun 2008 03:50:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C0008FC13
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 19 Jun 2008 03:50:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5J3o3XP007823
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 19 Jun 2008 03:50:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5J3o37a007822;
	Thu, 19 Jun 2008 03:50:03 GMT (envelope-from gnats)
Date: Thu, 19 Jun 2008 03:50:03 GMT
Message-Id: <200806190350.m5J3o37a007822@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Garrett Cooper" <yanefbsd@gmail.com>
Cc: 
Subject: Re: kern/124723: Typo in error message in ggated.c
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garrett Cooper <yanefbsd@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jun 2008 03:50:13 -0000

The following reply was made to PR kern/124723; it has been noted by GNATS.

From: "Garrett Cooper" <yanefbsd@gmail.com>
To: "Hywel Mallett" <Hywel@hmallett.co.uk>
Cc: bug-followup@freebsd.org
Subject: Re: kern/124723: Typo in error message in ggated.c
Date: Wed, 18 Jun 2008 20:41:15 -0700

 On Wed, Jun 18, 2008 at 9:44 AM, Hywel Mallett <Hywel@hmallett.co.uk> wrote:
 >
 >>Number:         124723
 >>Category:       kern
 >>Synopsis:       Typo in error message in ggated.c
 >>Confidential:   no
 >>Severity:       non-critical
 >>Priority:       low
 >>Responsible:    freebsd-bugs
 >>State:          open
 >>Quarter:
 >>Keywords:
 >>Date-Required:
 >>Class:          sw-bug
 >>Submitter-Id:   current-users
 >>Arrival-Date:   Wed Jun 18 16:50:01 UTC 2008
 >>Closed-Date:
 >>Last-Modified:
 >>Originator:     Hywel Mallett
 >>Release:        7-RELENG
 >>Organization:
 >>Environment:
 > FreeBSD one.option13.co.uk 7.0-STABLE FreeBSD 7.0-STABLE #0: Sun May  4 19:43:28 BST 2008     hywel@one.option13.co.uk:/usr/obj/usr/src/sys/GENERIC  amd64
 >
 >>Description:
 > In ggated there is an error message "No enough memory", which should (probably) read "Not enough memory".
 >>How-To-Repeat:
 >
 >>Fix:
 > Patch for src/sbin/ggate/ggated/ggated.c attached
 >
 >
 > Patch attached with submission follows:
 >
 > --- /usr/src/sbin/ggate/ggated/ggated.c 2006-12-18 11:12:00.000000000 +0000
 > +++ ggated.c    2008-06-18 17:39:26.000000000 +0100
 > @@ -211,10 +211,10 @@
 >
 >        ex = malloc(sizeof(*ex));
 >        if (ex == NULL)
 > -               g_gate_xlog("No enough memory.");
 > +               g_gate_xlog("Not enough memory.");
 >        ex->e_path = strdup(path);
 >        if (ex->e_path == NULL)
 > -               g_gate_xlog("No enough memory.");
 > +               g_gate_xlog("Not enough memory.");
 >
 >        /* Made 'and' here. */
 >        ex->e_ip = (ip & mask);
 
 That error message (IMO) is in and of itself misleading.
 
 strerror(errno) with g_gate_xlog(...) would be a more suitable means
 of denoting the error encountered.
 
 -Garrett