From owner-svn-src-all@FreeBSD.ORG Thu Dec 13 17:09:43 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DCE9773A; Thu, 13 Dec 2012 17:09:43 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id 438028FC17; Thu, 13 Dec 2012 17:09:43 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id bi5so1584617pad.13 for ; Thu, 13 Dec 2012 09:09:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=CG4lmcxxdcC8yNwuB3ibHhPRGlCNCqQL6Ydy375+a7U=; b=HMOD1TRLAySxtgxo6Y5EIvs5XFknFZRAzBwN2h5KxsKpH7+ervW5mOE7y/oalMMDmw GA/qP3FlarcckS5Q6ji8FH9nR3DO5x04VS6GDgqTvbK7XEh0rrR24KPPLKxdrYGDuNoz IW+Evwmb7dcsXj13sFdXfzKA94rXw0R/wiqb4B4kyVUYoJ+gbXff+AqwJfIpGVlma/3r l3YT/XsRDcZ0J+BDa8T3j9B3n/bWqmohy1VKsdByj2qbVcXmRskZjjVvvn0Krt4nNEXw l+6JTBtsgvOkWVgFe405xl//4IQwM547JDeuoGCjvH098u6makny2ukikLiAZhiBdqBF 4MjA== MIME-Version: 1.0 Received: by 10.68.192.70 with SMTP id he6mr7188640pbc.142.1355418085617; Thu, 13 Dec 2012 09:01:25 -0800 (PST) Sender: mdf356@gmail.com Received: by 10.68.55.166 with HTTP; Thu, 13 Dec 2012 09:01:25 -0800 (PST) In-Reply-To: <50C9A321.5060407@FreeBSD.org> References: <201212110708.qBB78EWx025288@svn.freebsd.org> <201212121046.43706.jhb@freebsd.org> <201212121658.49048.jhb@freebsd.org> <50C90567.8080406@FreeBSD.org> <50C909BD.9090709@mu.org> <50C97D94.1090603@FreeBSD.org> <50C97F8D.6010504@FreeBSD.org> <50C9A321.5060407@FreeBSD.org> Date: Thu, 13 Dec 2012 09:01:25 -0800 X-Google-Sender-Auth: 4TjBm-A58eBfQas6qmryVhHqCGs Message-ID: Subject: Re: svn commit: r244112 - head/sys/kern From: mdf@FreeBSD.org To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Cc: Adrian Chadd , Alfred Perlstein , John Baldwin , svn-src-all@freebsd.org, Alfred Perlstein , src-committers@freebsd.org, svn-src-head@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2012 17:09:44 -0000 On Thu, Dec 13, 2012 at 1:42 AM, Andriy Gapon wrote: > on 13/12/2012 09:16 Adrian Chadd said the following: >> Hi, >> >> I think the fundamental problem here is we have some pretty different >> ideas of what KASSERT should be, versus what it actually is in various >> parts of the code. > > Oh, and another part of the problem is that the discussion is opinion based. > But it didn't have to be. > > Compare this: > We think that feature F is a very good idea, we think that it will be used by many > people and it will provide a lot of benefits. So here you are - the code is in > the tree. > > To this: > We have been using feature F, it has proved to be a very good idea as it provided > these benefits and spared us from these problems. So here you are - the code is > in the tree. > > If I have a differing opinion in the first case I usually state it (and can be > pulled into an argument about it). If I have a different opinion in the second > case, I try to adjust my opinion to the stated reality. > >> Since we're lost in semantics, we're not going to get any further on >> this discussion just for now, so let's take a break and think about >> other things for now. Tools, not policy. A non-panic-ing KASSERT is a tool, not enabled by default. You don't need to use it. Someone does, so why can't we provide the tool? Thanks, matthew