From owner-svn-src-head@FreeBSD.ORG  Wed Jan 14 14:23:07 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6A36B421;
 Wed, 14 Jan 2015 14:23:07 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 42BE48D9;
 Wed, 14 Jan 2015 14:23:07 +0000 (UTC)
Received: from new-host.home (pool-173-70-85-31.nwrknj.fios.verizon.net
 [173.70.85.31])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 27534B91E;
 Wed, 14 Jan 2015 09:23:06 -0500 (EST)
Message-ID: <54B67BC9.70904@FreeBSD.org>
Date: Wed, 14 Jan 2015 09:23:05 -0500
From: John Baldwin <jhb@FreeBSD.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r277163 - head/sys/dev/cardbus
References: <201501140541.t0E5fV00070032@svn.freebsd.org>
In-Reply-To: <201501140541.t0E5fV00070032@svn.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Wed, 14 Jan 2015 09:23:06 -0500 (EST)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jan 2015 14:23:07 -0000

On 1/14/15 12:41 AM, Warner Losh wrote:
> Author: imp
> Date: Wed Jan 14 05:41:31 2015
> New Revision: 277163
> URL: https://svnweb.freebsd.org/changeset/base/277163
> 
> Log:
>   Add a rather obnoxious warning if you don't have NEW_PCIB defined
>   since it's a total crap shoot if things will work.

Should we just make it a #error instead?  (Some day I hope to have
NEW_PCIB enabled by default and remove the old code.  Will take a while
to get there for the generic PCI code, but cardbus is probably only used
on x86 so that would be fine.)

-- 
John Baldwin