From owner-cvs-src@FreeBSD.ORG Sat Sep 6 14:43:41 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B569D1065689; Sat, 6 Sep 2008 14:43:41 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id AD9828FC1D; Sat, 6 Sep 2008 14:43:41 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m86EhfcQ015204; Sat, 6 Sep 2008 14:43:41 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m86EhfGP015182; Sat, 6 Sep 2008 14:43:41 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200809061443.m86EhfGP015182@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Sat, 6 Sep 2008 14:43:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern tty.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Sep 2008 14:43:41 -0000 ed 2008-09-06 14:43:32 UTC FreeBSD src repository Modified files: sys/kern tty.c Log: SVN rev 182815 on 2008-09-06 14:43:32Z by ed Make TIOCCONS use priv_check() instead of checking /dev/console permissions. As discussed with Robert on IRC, checking the permissions on /dev/console to see if we can call TIOCCONS could be unreliable. When we run a chroot() without a devfs instance mounted inside, it won't actually check the permissions on the device node inside the devfs instance. Using the already existing PRIV_TTY_CONSOLE for this seems like a better idea. Approved by: rwatson Revision Changes Path 1.288 +8 -35 src/sys/kern/tty.c