From nobody Wed Jan 14 15:38:27 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drqyp204Dz6NZ2c for ; Wed, 14 Jan 2026 15:38:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drqyn5Ql7z4NyQ for ; Wed, 14 Jan 2026 15:38:41 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-c0bccb8037eso3741063a12.1 for ; Wed, 14 Jan 2026 07:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1768405118; x=1769009918; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xHbEMk0PcV+UtT2FstM1p9OdvPNrCd+5akAMUoFo/+o=; b=hF0dXLeeyDQ5uaF2G52NwKJtptPxkFZBXHVUWfhuLwwYRgCJsVYYIFQ/WpDoFky/ny +LFYMtlgksY3IgCryIWx7DRKlqH7hhpCrM5bcESURf0KQT9w6s5fBiZyVNDemMrh7TVM et+bifluWxPXwBP8U0jOUn4X+HxRSISmlCw0pEJTL7vISMfWsRWpX1H5zn5gyrwJCSnh gE3gRLxRbrDg3E+WkbIRkr1uhBpsshChXCzT0+dT4VlSzA+D1GAkSX0DozrqeFc5D/CA uenDLD12Gonn8yrf+UPyuMWoA5XFFYQOMKoADVGqtaVfWW6akBgPs0eNybwR2qHORque AaWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768405118; x=1769009918; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xHbEMk0PcV+UtT2FstM1p9OdvPNrCd+5akAMUoFo/+o=; b=E2Ta3iJ30t3JJA6ljyew0nqCbwIlKtPEhR5n5QONV05WNlwgKu3mUbrE9wAwmEa45l 0PuU7dKsLVWI+nV8VcWcTbIynNdP/Bq7At8V//5H9KXrS5sPMpNRx6lQ2EtdbmkYznKX kPJdv1Eu6qcYlq8D8nWGOala0gRK57XjWZYEZE+Cz5ThF24BjkoNdpdCOSiB8/it+I6f 9GSfW1o3qekHhFpu1qdDS479XegbK4zWIqxrP6CKVE43KIXdXUY3EA9NnM+3dTVjkSGC SfNGeDZD0Y5Zk55n/SUmPGkDFxBqYx9VzV21LDE5vU211I3cmwehjDqanrVYch7fTdBW uLnQ== X-Forwarded-Encrypted: i=1; AJvYcCUhSA3eJLiTyi/NYHafr3em6hayiG16qhmquqprLHzm3LKOYbXAI5t4FfwUe1xrPlB+mLyvikQ/IlHN9VsqCfZbebuICw==@freebsd.org X-Gm-Message-State: AOJu0YzgwjB6u6ur3GIJukrXd0bjYxyHrK/fAAit5sgMr2Yw4bDYQ3bm 0s2UWcrcFq/YXsV/o9udirQiFiT26JQGQXXox4Vc0htZSbLq57MEMgifRwu7wu90bI5UwW5KiqR LJNVLAEXQmkXm1AeCK2lkaXYvSx+CsrKIAOhGoIBSY/YojEoNQVhF X-Gm-Gg: AY/fxX5/WR4j5kwiyZDOkEcd9O21Kh2/7yivTYY++ky/xCRyQ8Hil/34ohof7AWfN9N 348nrknjFZg6Tn0fQlGX2Evsgv80wwtCOw0k55xUcfRwutVy94JaDVcN5VbeZGo0TCFFLnWx0mY 47c2qgjtx1eZREFn9NMm1VDKCskb0CwRkBzH4mawKrlMSO6sVN5Yi4PxEr1CLqx6clQkx4PSAcp MyVHI2ipKpY6PRiWP70GK5Q/8tFKqQsLacVo1rdQC0Js1WoBvtnaF0jlI1I3k8IuKRxgbA= X-Received: by 2002:a17:90b:5547:b0:33b:ba50:fccc with SMTP id 98e67ed59e1d1-35109117519mr3082782a91.18.1768405118559; Wed, 14 Jan 2026 07:38:38 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> <6e64a14f-1fa0-45ec-b73b-e84f1dbb8153@FreeBSD.org> <86jyxkfeo9.fsf@ltc.des.dev> In-Reply-To: <86jyxkfeo9.fsf@ltc.des.dev> From: Warner Losh Date: Wed, 14 Jan 2026 08:38:27 -0700 X-Gm-Features: AZwV_QiWYqD2tsrTJfUw8ceaeUf9SAtpbobItP4DA7VVksnqyEJwYvsKJkaf8Sc Message-ID: Subject: Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: John Baldwin , Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000e9367906485ae61b" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4drqyn5Ql7z4NyQ --000000000000e9367906485ae61b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 14, 2026 at 7:32=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav wrote: > Warner Losh writes: > > John Baldwin writes: > > > sys/crypto isn't really the same. We store the generated OpenSSL > > > assembly files there for use by ossl(4), but most of sys/crypto is > > > not vendored (e.g. ccp, the non-assembly ossl bits, aesni are all > > > just bespoke). > > That's the beauty of this: We can have whatever we want here... These > > were placeholders until we had more nuanced things. I see things like > > openssh in crypto too, so many things are vendored there, in addition > > to the mire of inconsistency... > > crypto is nearly fully vendored, sys/crypto is mostly not, don't confuse > the two... > Sure. So what's the actionable suggestion? Warner --000000000000e9367906485ae61b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 14,= 2026 at 7:32=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> wrote:
Warner Losh <imp@bsdimp.com> writes:
> John Baldwin <= jhb@freebsd.org> writes:
> > sys/crypto isn't really the same.=C2=A0 We store the generate= d OpenSSL
> > assembly files there for use by ossl(4), but most of sys/crypto i= s
> > not vendored (e.g. ccp, the non-assembly ossl bits, aesni are all=
> > just bespoke).
> That's the beauty of this: We can have whatever we want here...=C2= =A0 These
> were placeholders until we had more nuanced things. I see things like<= br> > openssh in crypto too, so many things are vendored there, in addition<= br> > to the mire of inconsistency...

crypto is nearly fully vendored, sys/crypto is mostly not, don't confus= e
the two...

Sure. So what's the acti= onable suggestion?

Warner
--000000000000e9367906485ae61b--