From owner-svn-src-head@freebsd.org Wed Mar 14 14:53:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 947D2F56DFF; Wed, 14 Mar 2018 14:53:37 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1F8E48464D; Wed, 14 Mar 2018 14:53:36 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (cpe-75-82-218-62.socal.res.rr.com [75.82.218.62]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id w2EErXkH006774 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 14 Mar 2018 07:53:34 -0700 Subject: Re: svn commit: r330925 - in head/sys: conf powerpc/powernv To: Ian Lepore , Wojciech Macek , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201803140920.w2E9K3mn019118@repo.freebsd.org> <1521037280.84937.285.camel@freebsd.org> From: Nathan Whitehorn Message-ID: <35bd7933-3d70-3e3f-1400-467ca6b9b561@freebsd.org> Date: Wed, 14 Mar 2018 07:53:33 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521037280.84937.285.camel@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVY3OLlw8Wbf75t+CumguRFq1HzQySHQ01HGbXNVIh97Xlzwf++3AkvUPc5wnF2SE9ecfYaYKkrzyeDy4kqAtEgsuRXQE6QQIfs= X-Sonic-ID: C;ekDAd5cn6BGlXiAFsE207w== M;hIL7d5cn6BGlXiAFsE207w== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 14:53:37 -0000 On 03/14/18 07:21, Ian Lepore wrote: > On Wed, 2018-03-14 at 09:20 +0000, Wojciech Macek wrote: >> Author: wma >> Date: Wed Mar 14 09:20:03 2018 >> New Revision: 330925 >> URL: https://svnweb.freebsd.org/changeset/base/330925 >> >> Log: >>   PowerNV: Fix I2C to compile if FDT is disabled >> >>   Submitted by:          Wojciech Macek >>   Obtained from:         Semihalf >>   Sponsored by:          IBM, QCM Technologies >> > This seems to be a nonsensical commit.  What's the point of compiling > in a driver which is hard-coded to return failure from the probe and > attach routines?  The pre-change code seemed more correct: the driver > can only possibly work if FDT/OFW data is available, so only compile it > in when that option is in effect. > > -- Ian > It's even worse than that: the files.powerpc uses of fdt are *also* wrong, because it depends on OF, not FDT per se, which is unconditionally available on all AIM-type PowerPC kernels, so there is no need to test for *anything*. -Nathan